r52672 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52671‎ | r52672 | r52673 >
Date:01:00, 2 July 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 11242) Check for MySQL storage engines during installation doesn't check whether engine is actually available. Patch by Jan Reininghaus.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/config/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/index.php
@@ -1170,7 +1170,7 @@
11711171 $res = $wgDatabase->query( 'SHOW ENGINES' );
11721172 $found = false;
11731173 while ( $row = $wgDatabase->fetchObject( $res ) ) {
1174 - if ( $row->Engine == $conf->DBengine ) {
 1174+ if ( $row->Engine == $conf->DBengine && ( $row->Support == 'YES' || $row->Support == 'DEFAULT' ) ) {
11751175 $found = true;
11761176 break;
11771177 }
Index: trunk/phase3/RELEASE-NOTES
@@ -218,6 +218,8 @@
219219 via extensions not using the userCan hook and via $wgRevokePermissions now work.
220220 * (bug 8445) Multiple-character search terms are now handled properly for Chinese
221221 * (bug 19450) Use formatNum for "Number of edits" in Special:Preferences
 222+* (bug 11242) Check for MySQL storage engines during installation now checks
 223+ whether the engines are actually available
222224
223225 == API changes in 1.16 ==
224226

Follow-up revisions

RevisionCommit summaryAuthorDate
r63212Merged r52672 into new-installermaxsem18:13, 3 March 2010

Status & tagging log