r52671 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52670‎ | r52671 | r52672 >
Date:00:55, 2 July 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Use wfGetNull() instead of hardcoded /dev/null
Modified paths:
  • /trunk/phase3/includes/ProxyTools.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProxyTools.php
——@@ -174,7 +174,7 @@
175175 escapeshellarg( $port ),
176176 escapeshellarg( $url )
177177 ));
178 - exec( "php $params &>/dev/null &" );
 178+ exec( "php $params &>" . wfGetNull() . " &" );
179179 }
180180 # Set MemCached key
181181 $wgMemc->set( $mcKey, 1, $wgProxyMemcExpiry );

Follow-up revisions

RevisionCommit summaryAuthorDate
r55575Followup to r52671, fix redirection syntax to work with windows as well.overlordq15:47, 25 August 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:12, 22 August 2009

I don't think this'll be terribly helpful as the command-line syntax will still fail on Windows: 

C:\Documents and Settings\Owner>echo foo &> NUL
The syntax of the command is incorrect.
#Comment by 😂 (talk | contribs)   22:58, 25 August 2009
  • Should* be resolved with r55575.

Status & tagging log