r52618 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52617‎ | r52618 | r52619 >
Date:00:55, 1 July 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 19428) PG and MySQL followups to r52503. Patch by OverlordQ
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-l10n_cache.sql (modified) (history)
  • /trunk/phase3/maintenance/postgres/archives/patch-l10n_cache.sql (added) (history)
  • /trunk/phase3/maintenance/postgres/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-l10n_cache.sql
——@@ -3,6 +3,6 @@
44 lc_lang varbinary(32) NOT NULL,
55 lc_key varchar(255) NOT NULL,
66 lc_value mediumblob NOT NULL
7 -);
 7+) /*$wgDBTableOptions*/;
88 CREATE INDEX /*i*/lc_lang_key ON /*_*/l10n_cache (lc_lang, lc_key);
99
Index: trunk/phase3/maintenance/postgres/archives/patch-l10n_cache.sql
——@@ -0,0 +1,8 @@
 2+CREATE TABLE l10n_cache (
 3+ lc_lang TEXT NOT NULL,
 4+ lc_key TEXT NOT NULL,
 5+ lc_value TEXT NOT NULL
 6+);
 7+CREATE INDEX l10n_cache_lc_lang_key ON l10n_cache (lc_lang, lc_key);
 8+
 9+
Property changes on: trunk/phase3/maintenance/postgres/archives/patch-l10n_cache.sql
___________________________________________________________________
Added: svn:eol-style
110 + native
Index: trunk/phase3/maintenance/postgres/tables.sql
——@@ -616,3 +616,9 @@
617617 INSERT INTO mediawiki_version (type,mw_version,sql_version,sql_date)
618618 VALUES ('Creation','??','$LastChangedRevision$','$LastChangedDate$');
619619
 620+CREATE TABLE l10n_cache (
 621+ lc_lang TEXT NOT NULL,
 622+ lc_key TEXT NOT NULL,
 623+ lc_value TEXT NOT NULL
 624+);
 625+CREATE INDEX l10n_cache_lc_lang_key ON l10n_cache (lc_lang, lc_key);
Index: trunk/phase3/maintenance/updaters.inc
——@@ -1489,6 +1489,7 @@
14901490 array('valid_tag', 'patch-change_tag.sql'),
14911491 array('user_properties', 'patch-user_properties.sql'),
14921492 array('log_search', 'patch-log_search.sql'),
 1493+ array('l10n_cache', 'patch-l10n_cache.sql'),
14931494 );
14941495
14951496 $newcols = array(
Index: trunk/phase3/maintenance/tables.sql
——@@ -1318,7 +1318,7 @@
13191319 lc_key varchar(255) NOT NULL,
13201320 -- Value
13211321 lc_value mediumblob NOT NULL
1322 -);
 1322+) /*$wgDBTableOptions*/;
13231323 CREATE INDEX /*i*/lc_lang_key ON /*_*/l10n_cache (lc_lang, lc_key);
13241324
13251325 -- vim: sw=2 sts=2 et

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52503* Introduced a new system for localisation caching. The system is based aroun...tstarling07:11, 28 June 2009

Comments

#Comment by Raymond (talk | contribs)   10:38, 1 July 2009

Still unable to update (running HEAD with MySQL on Windows): 

F:\xampp\htdocs\wiki2\maintenance>php update.php
A database error has occurred
Query: SELECT  lc_value  FROM `l10n_cache`  WHERE lc_lang = 'de' AND lc_key = 'deps'  LIMIT 1
Function: LCStore_DB::get
Error: 1146 Table 'wikidb.l10n_cache' doesn't exist (localhost)
#Comment by OverlordQ (talk | contribs)   22:24, 1 July 2009

Bug 19447 for that issue

#Comment by 😂 (talk | contribs)   10:41, 1 July 2009

See, this is weird. I was able to update just fine (even prior to this commit). Same environment.

#Comment by Raymond (talk | contribs)   10:59, 1 July 2009

What is your content language? Mine is 'de'.

#Comment by 😂 (talk | contribs)   11:12, 1 July 2009

En. This bug is unrelated to the fixes I committed. The bug in question was filed for failed upgrades on non-en installs (its a blocker, don't have the number offhand). Afaict, this commit for these issues is fine, althoough no, it doesn't fix the upgrade problem.

Status & tagging log