r52582 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52581‎ | r52582 | r52583 >
Date:21:38, 29 June 2009
Author:tparscal
Status:ok
Tags:
Comment:
Divided stylesheets into LTR and RTL versions, but also reverted strange hacks to make things sort of work in may browsers. Still need to solve RTL problems in browsers with certain CSS limitations.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -35,8 +35,13 @@
3636 * @param object $out Output page to add styles to
3737 */
3838 public function setupSkinUserCss( OutputPage $out ) {
 39+ global $wgContLang;
3940 // Append to the default screen common & print styles...
40 - $out->addStyle( 'vector/main.css', 'screen' );
 41+ if ( $wgContLang->isRTL() ) {
 42+ $out->addStyle( 'vector/main-rtl.css', 'screen' );
 43+ } else {
 44+ $out->addStyle( 'vector/main-ltr.css', 'screen' );
 45+ }
4146 // Add common styles
4247 parent::setupSkinUserCss( $out );
4348 }

Status & tagging log