r52563 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52562‎ | r52563 | r52564 >
Date:17:58, 29 June 2009
Author:purodha
Status:deferred
Tags:
Comment:
Date and time split in message. See also User EugeneZelenko at
http://translatewiki.net/w/i.php?title=Support&oldid=1286170#Confirmaccount-reject
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)
  • /trunk/extensions/Translate/check-blacklist.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/check-blacklist.php
@@ -99,6 +99,8 @@
100100 'check' => 'variable',
101101 'message' => array(
102102 'requestaccount-email-body', // Optional time parameters
 103+ 'confirmaccount-reject', // Optional time parameters
 104+ 'confirmaccount-held', // Optional time parameters
103105 )
104106 ),
105107 array(
Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -214,23 +214,27 @@
215215 $wgOut->addWikiText( wfMsg( "confirmaccount-text" ) );
216216
217217 if( $row->acr_rejected ) {
218 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_rejected), true );
 218+ $datim = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_rejected), true );
 219+ $date = $wgLang->date( wfTimestamp(TS_MW, $row->acr_rejected), true );
 220+ $time = $wgLang->time( wfTimestamp(TS_MW, $row->acr_rejected), true );
219221 $reason = $row->acr_comment ? $row->acr_comment : wfMsgHtml('confirmaccount-noreason');
220222 # Auto-rejected requests have a user ID of zero
221223 if( $row->acr_user ) {
222224 $wgOut->addHTML('<p><b>'.wfMsgExt( 'confirmaccount-reject', array('parseinline'),
223 - User::whoIs($row->acr_user), $time ).'</b></p>');
 225+ User::whoIs($row->acr_user), $datim, $date, $time ).'</b></p>');
224226 $wgOut->addHTML( '<p><strong>' . wfMsgHtml('confirmaccount-rational') . '</strong><i> ' .
225227 $reason . '</i></p>' );
226228 } else {
227229 $wgOut->addHTML( '<p><i> ' . $reason . '</i></p>' );
228230 }
229231 } else if( $row->acr_held ) {
230 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_held), true );
 232+ $datim = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_held), true );
 233+ $date = $wgLang->date( wfTimestamp(TS_MW, $row->acr_held), true );
 234+ $time = $wgLang->time( wfTimestamp(TS_MW, $row->acr_held), true );
231235 $reason = $row->acr_comment ? $row->acr_comment : wfMsgHtml('confirmaccount-noreason');
232236
233237 $wgOut->addHTML('<p><b>'.wfMsgExt( 'confirmaccount-held', array('parseinline'),
234 - User::whoIs($row->acr_user), $time ).'</b></p>');
 238+ User::whoIs($row->acr_user), $datim, $date, $time ).'</b></p>');
235239 $wgOut->addHTML( '<p><strong>' . wfMsgHtml('confirmaccount-rational') . '</strong><i> ' .
236240 $reason . '</i></p>' );
237241 }
@@ -876,11 +880,15 @@
877881 $r .= $time." (<strong>{$link}</strong>)";
878882 # Auto-rejected accounts have a user ID of zero
879883 if( $row->acr_rejected && $row->acr_user ) {
880 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_rejected), true );
881 - $r .= ' <b>'.wfMsgExt( 'confirmaccount-reject', array('parseinline'), $row->user_name, $time ).'</b>';
 884+ $datim = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_rejected), true );
 885+ $date = $wgLang->date( wfTimestamp(TS_MW, $row->acr_rejected), true );
 886+ $time = $wgLang->time( wfTimestamp(TS_MW, $row->acr_rejected), true );
 887+ $r .= ' <b>'.wfMsgExt( 'confirmaccount-reject', array('parseinline'), $row->user_name, $datim, $date, $time ).'</b>';
882888 } else if( $row->acr_held && !$row->acr_rejected ) {
883 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_held), true );
884 - $r .= ' <b>'.wfMsgExt( 'confirmaccount-held', array('parseinline'), User::whoIs($row->acr_user), $time ).'</b>';
 889+ $datim = $wgLang->timeanddate( wfTimestamp(TS_MW, $row->acr_held), true );
 890+ $date = $wgLang->date( wfTimestamp(TS_MW, $row->acr_held), true );
 891+ $time = $wgLang->time( wfTimestamp(TS_MW, $row->acr_held), true );
 892+ $r .= ' <b>'.wfMsgExt( 'confirmaccount-held', array('parseinline'), User::whoIs($row->acr_user), $datim, $date, $time ).'</b>';
885893 }
886894 # Check if someone is viewing this request
887895 global $wgMemc;
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php
@@ -289,7 +289,17 @@
290290 'confirmaccount-notes' => '{{Identical|Additional notes}}',
291291 'confirmaccount-urls' => '{{Identical|List of websites}}',
292292 'confirmaccount-none-p' => '{{Identical/Notprovided}}',
 293+ 'confirmaccount-reject' => 'Parameters:
 294+*$1 user name
 295+*$2 date/time
 296+*$3 date
 297+*$4 time',
293298 'confirmaccount-noreason' => '{{Identical|None}}',
 299+ 'confirmaccount-held' => 'Parameters:
 300+*$1 user name
 301+*$2 date/time
 302+*$3 date
 303+*$4 time',
294304 'confirmaccount-ip' => '{{Identical|IP Address}}',
295305 'confirmaccount-submit' => '{{Identical|Confirm}}',
296306 'confirmaccount-welc' => 'In ConfirmAccount extension. A welcome message that is automatically placed on the talk pages of new users.',

Status & tagging log