r52555 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52554‎ | r52555 | r52556 >
Date:17:06, 29 June 2009
Author:shinjiman
Status:ok
Tags:
Comment:
revert r52546 and r52550 for slow loading for the class, per CodeReview.
Modified paths:
  • /trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php (modified) (history)
  • /trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.php
@@ -61,11 +61,6 @@
6262 $wgExtensionFunctions[] = 'efSyntaxHighlight_GeSHiSetup';
6363 }
6464
65 -if ( file_exists( $dir . 'geshi/geshi.php' ) ) {
66 - require_once( 'geshi/geshi.php' );
67 - $wgExtensionCredits['parserhook']['SyntaxHighlight_GeSHi']['version'] = GESHI_VERSION;
68 -}
69 -
7065 /**
7166 * Register parser hook
7267 */
Index: trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
@@ -306,7 +306,7 @@
307307 if( !self::$initialised ) {
308308 wfLoadExtensionMessages( 'SyntaxHighlight_GeSHi' );
309309 if( !class_exists( 'GeSHi' ) )
310 - require_once( 'geshi/geshi.php' );
 310+ require( 'geshi/geshi.php' );
311311 self::$initialised = true;
312312 }
313313 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r52642show the version information of GeSHi currently using, only show the version ...shinjiman19:34, 1 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52546show the version information of GeSHi currently using, only show the version ...shinjiman15:07, 29 June 2009
r52550tweak for r52546, use require_once() to make the class file only load once.shinjiman16:29, 29 June 2009

Status & tagging log