r52530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52529‎ | r52530 | r52531 >
Date:21:01, 28 June 2009
Author:aaron
Status:deferred
Tags:
Comment:
Removed excess check and broke a long line
Modified paths:
  • /trunk/extensions/ConfirmAccount/RequestAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/RequestAccount_body.php
@@ -248,7 +248,7 @@
249249 $wgCaptchaTriggers['createaccount'] = $old;
250250 }
251251 # No request spamming...
252 - if ( $wgAccountRequestThrottle && ( !method_exists( $wgUser, 'isPingLimitable' ) || $wgUser->isPingLimitable() ) ) {
 252+ if ( $wgAccountRequestThrottle && $wgUser->isPingLimitable() ) {
253253 global $wgMemc;
254254 $key = wfMemcKey( 'acctrequest', 'ip', wfGetIP() );
255255 $value = $wgMemc->get( $key );
@@ -286,7 +286,8 @@
287287 # Check if biography is long enough
288288 if ( str_word_count( $this->mBio ) < $wgAccountRequestMinWords ) {
289289 global $wgLang;
290 - $this->showForm( wfMsgExt( 'requestaccount-tooshort', 'parsemag', $wgLang->formatNum( $wgAccountRequestMinWords ) ) );
 290+ $this->showForm( wfMsgExt( 'requestaccount-tooshort', 'parsemag',
 291+ $wgLang->formatNum( $wgAccountRequestMinWords ) ) );
291292 return;
292293 }
293294 # Set some additional data so the AbortNewAccount hook can be
@@ -390,7 +391,7 @@
391392 $wgMemc->delete( $key );
392393 # No request spamming...
393394 # BC: check if isPingLimitable() exists
394 - if ( $wgAccountRequestThrottle && ( !method_exists( $wgUser, 'isPingLimitable' ) || $wgUser->isPingLimitable() ) ) {
 395+ if ( $wgAccountRequestThrottle && $wgUser->isPingLimitable() ) {
395396 $key = wfMemcKey( 'acctrequest', 'ip', wfGetIP() );
396397 if ( !$value = $wgMemc->incr( $key ) ) {
397398 $wgMemc->set( $key, 1, 86400 );

Status & tagging log