r52480 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52479‎ | r52480 | r52481 >
Date:09:01, 27 June 2009
Author:shinjiman
Status:reverted
Tags:
Comment:
fix for r52476, include the cases with quotation marks.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -113,7 +113,7 @@
114114
115115 // Look for ImageMagick's version, if did not found, try to find the GD library version
116116 if ( $wgUseImageMagick === true ) {
117 - if ( file_exists( $wgImageMagickConvertCommand ) ) {
 117+ if ( file_exists( trim( $wgImageMagickConvertCommand, '"' ) ) ) {
118118 $swImageMagickInfo = self::execOutput( $wgImageMagickConvertCommand . ' -version' );
119119 list( $head, $tail ) = explode( 'ImageMagick', $swImageMagickInfo );
120120 list( $swImageMagickVer ) = explode('http://www.imagemagick.org', $tail );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52476* (bug 14611) Added support showing the version of the image thumbnailing eng...shinjiman21:58, 26 June 2009

Status & tagging log