r52421 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52420‎ | r52421 | r52422 >
Date:21:37, 25 June 2009
Author:dale
Status:deferred
Tags:
Comment:
removed some settings that are stored in global defaultSettings now
updated a msg to use wikitext
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/MV_Settings.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_Title.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/add_media_wizard.OFF.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_allpages.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/MV_Settings.php
@@ -16,25 +16,19 @@
1717
1818 define( 'SEQUENCE_TAG', 'sequence_hlrd' );
1919
20 -// include the global functions & register the extension
 20+// include the global functions & register the extension
2121 include_once( 'MV_GlobalFunctions.php' );
2222
2323
24 -//greatly affects site performance (turn to false to avoid costly parent lookups on all search results) :
 24+//greatly affects site performance (turn to false to avoid costly parent lookups on all search results) :
2525 $mvGetParentMeta = true;
2626
2727
28 -//script loader settings:
29 -$mvgJSDebug=false;
30 -$wgEnableScriptLoader = false; //if the script loader is on
 28+//script loader settings:
3129
32 -$wgEnableScriptLoaderJsFile = true; //if you can use the script loader with js files (rather than only js classes)
33 -$wgEnableScriptMinify = true;
3430
35 -
36 -
3731 // if the search portlet should autoComplete
38 -// (causes the inclution of jquery into every page.. can slow things down a bit)
 32+// (causes the inclution of jquery into every page.. can slow things down a bit)
3933 $mvEnableAutoComplete = true;
4034
4135
@@ -46,9 +40,9 @@
4741 # semanticWiki integration options
4842 # #########################
4943 // @@todo we should clean this up!... into a semantic maping array or object
50 -// if you want to include spoken by relation in search results:
 44+// if you want to include spoken by relation in search results:
5145
52 -// enable dissable varius digest data collection
 46+// enable dissable varius digest data collection
5347 $mvEnableSearchDigest = true;
5448 $mvEnableClipViewDigest = true;
5549 // keeps track of popular pages in given categories over time
@@ -58,7 +52,7 @@
5953 // 'property'=>category for auto_complete (ALL LOWER CASE)
6054 $mvMetaDataHelpers = array( 'anno_en' => array( 'speech_by' => 'person', 'bill' => 'bill' ) );
6155
62 -// by default categories are handled differently enable or disable below:
 56+// by default categories are handled differently enable or disable below:
6357 $mvMetaCategoryHelper = true;
6458
6559
@@ -70,41 +64,41 @@
7165
7266
7367 # ########################
74 -# metavid paths
 68+# metavid paths
7569 # @@todo clean up with internal handlers for annodex and images
76 -# use the mediaWiki defaults for storage of media
 70+# use the mediaWiki defaults for storage of media
7771 # #########################
7872
7973 // define the image location:
8074 // $mvImageWebLoc ='http://metavid.org/image_media/';
8175
82 -// if we should load images from an external server:
 76+// if we should load images from an external server:
8377 $mvExternalImages = false;
84 -// path to metavidWiki install that is serving images:
 78+// path to metavidWiki install that is serving images:
8579 $mvExternalImgServerPath = 'http://mvprime.cse.ucsc.edu/wiki/index.php';
8680
8781 $mvWebImgLoc = $mvgScriptPath . '/stream_images';
88 -// full local path for images (if hosted locally)
 82+// full local path for images (if hosted locally)
8983 $mvLocalImgLoc = $mvgIP . '/stream_images';
9084
9185 // if mediaWiki should serve up redirects to image file path or have php send the image via GD
9286 // if served directly its one less round trip to the server but may tax the server
93 -// a bit more than having apache serving the file
 87+// a bit more than having apache serving the file
9488 $mvServeImageRedirect = false;
9589
9690 // the time in seconds of between image frames generated from movie clips.
97 -// (set pretty high for the metavid context where we load the images via scripts
 91+// (set pretty high for the metavid context where we load the images via scripts
9892 // (early on we did less frequent image grabs)
99 -// normally you would want a lower value like 5 seconds or so
 93+// normally you would want a lower value like 5 seconds or so
10094 $mvImageGranularityRate = '600';
10195 // the ffmpeg command to generate thumbnail (to disable generating images set to '')
10296 $mvShellOggFrameGrab = '';
103 -
104 -# define the video media locations based on path/server names
 97+
 98+# define the video media locations based on path/server names
10599 $mvVideoArchivePaths['cap1'] = 'http://metavidstorage01.ucsc.edu/media/';
106100 $mvVideoArchivePaths['mvbox2'] = 'http://mvbox2.cse.ucsc.edu/media/';
107101
108 -// stream msgKeys that support ?t=start_time/end_time temporal url media serving:
 102+// stream msgKeys that support ?t=start_time/end_time temporal url media serving:
109103 $mvDefaultVideoQualityKey = 'mv_ogg_low_quality';
110104 $mvDefaultFlashQualityKey = 'mv_flash_low_quality';
111105 $mvDefaultVideoHighQualityKey = 'mv_ogg_high_quality';
@@ -141,7 +135,7 @@
142136 //if to display the ROE resource link
143137 $mvDispROEicon=false;
144138
145 -//The text Embed a metavid Stream inline in the wiki
 139+//The text Embed a metavid Stream inline in the wiki
146140 $mvEmbedKey = 'Embed';
147141
148142 //wars people of archive inacuracys (given its a wiki and the source is close caption feed)
@@ -163,7 +157,7 @@
164158 */
165159 $mvMVDTypeDefaultDisp = array( 'ht_en', 'anno_en' );
166160
167 -//if we should show the layer controls:
 161+//if we should show the layer controls:
168162 $mvgShowLayerControls = false;
169163
170164 # ##################
@@ -181,12 +175,12 @@
182176 # @@todo should really integrate "streams" with "media"
183177 # here you can control what rights 'sysop', 'bot', 'user', 'anonymous', have in
184178 # adding streams
185 -# note: all streams are treated equally once added to the system
 179+# note: all streams are treated equally once added to the system
186180 # (this only control import types)
187181 #
188182 # type: [metavid_file] -- used for pointing to an existing file on the server
189 -# [metavid_live] -- used for the setting up the scripts for a live stream.
190 -# [upload_file] -- used video file uploads
 183+# [metavid_live] -- used for the setting up the scripts for a live stream.
 184+# [upload_file] -- used video file uploads
191185 # [external_file] -- used to add external files via http urls (such as a file from archive.org)
192186 $mvStreamTypePermission['metavid_file'] = array( 'sysop', 'bot' );
193187 $mvStreamTypePermission['metavid_live'] = array();
@@ -209,7 +203,7 @@
210204
211205 'mv_archive_org_mp4' => 'video/h264',
212206 'mv_flash_low_quality' => 'video/x-flv',
213 - 'mv_ogg_high_quality' => 'video/ogg',
 207+ 'mv_ogg_high_quality' => 'video/ogg',
214208 'mv_ogg_low_quality' => 'video/ogg'
215209 );
216210
@@ -218,8 +212,8 @@
219213 # $mvNamespaceIndex = ???; in your config before including the settings
220214 # should be larger than 100 and if you put in a default value
221215 # if your using semantic wiki just init the semantic wiki namespace
222 -# and metavid will take subsequent NS values accordingly.
223 -# #
 216+# and metavid will take subsequent NS values accordingly.
 217+# #
224218 if ( !isset( $mvNamespaceIndex ) ) {
225219 mvInitNamespaces( 100 );
226220 } else {
Index: trunk/extensions/MetavidWiki/includes/MV_Title.php
@@ -4,15 +4,15 @@
55 *
66 * All Metavid Wiki code is Released under the GPL2
77 * for more info visit http://metavid.org/wiki/Code
8 - *
 8+ *
99 * @author Michael Dale
1010 * @email dale@ucsc.edu
1111 * @url http://metavid.org
12 - *
 12+ *
1313 */
1414 if ( !defined( 'MEDIAWIKI' ) ) die( 1 );
15 -
16 - /*@@TODO document
 15+
 16+ /*@@TODO document
1717 * @@todo title implementation is a bit messy ..
1818 * MV_Title should really just extend title and be passed around as a title
1919 * instead of having two objects (Title and MV_title)
@@ -24,15 +24,15 @@
2525 var $end_time = null;
2626 var $id = null;
2727 var $view_count = null;
28 -
 28+
2929 var $hasMVDType = false;
3030 var $dispVideoPlayerTime = false;
31 - // a pointer to the mvStream
 31+ // a pointer to the mvStream
3232 var $mvStream = null;
3333 var $wiki_title = '';
3434 // default namespace for mvTitle MV_NS_MVD
35 - function __construct( $title, $ns = MV_NS_MVD ) {
36 - // handle title object
 35+ function __construct( $title, $ns = MV_NS_MVD ) {
 36+ // handle title object
3737 if ( is_string( $title ) ) {
3838 $title = parent::makeTitle( $ns, $title );
3939 }
@@ -46,14 +46,14 @@
4747 function inheritTitle( & $title ) {
4848 if( !is_object($title)){
4949 //print_r( debug_backtrace() );
50 - return false;
 50+ return false;
5151 }
5252 foreach ( $title as $k => $v ) {
5353 $this->$k = $v;
5454 }
5555 }
5656 function hasMVDType() { return $this->hasMVDType; }
57 - /*
 57+ /*
5858 * checks if the given request is valid:
5959 * valid request include:
6060 * type:existing_stream/##:##:##(/##:##:##)?
@@ -62,7 +62,7 @@
6363 // @@todo should throw use exceptions
6464 // first check if stream exists
6565 if ( !$this->doesStreamExist() ) {
66 - // print "stream does not exist";
 66+ // print "stream does not exist";
6767 return false;
6868 }
6969 if ( !$this->hasMVDType() ) {
@@ -76,7 +76,7 @@
7777 return true;
7878 }
7979 /*
80 - * Check the db for the given stream name
 80+ * Check the db for the given stream name
8181 */
8282 function doesStreamExist() {
8383 // print "looking for: ". $this->stream_name;
@@ -88,7 +88,7 @@
8989 function getStreamName() { return $this->stream_name; }
9090 /*
9191 * Returns the stream name with uppercase first word
92 - * and spaces for underscores
 92+ * and spaces for underscores
9393 */
9494 function getStreamNameText( $sn = '' ) {
9595 if ( $sn == '' )$sn = $this->stream_name;
@@ -98,11 +98,11 @@
9999 $d = $this->mvStream->getStreamStartDate();
100100 if(!isset($d) || $d==0)
101101 return $this->getStreamNameText();
102 - $sn_parts = split('_',$this->stream_name);
103 - //remove the date part of the array:
 102+ $sn_parts = split('_',$this->stream_name);
 103+ //remove the date part of the array:
104104 array_pop( $sn_parts);
105105 foreach($sn_parts as & $sp)
106 - $sp = ucfirst($sp);
 106+ $sp = ucfirst($sp);
107107 $sn = (count($sn_parts)>1)? implode(' ', $sn_parts): $sp[0];
108108 return $sn .' on '. date('M jS, Y',$d);
109109 }
@@ -126,28 +126,28 @@
127127 function getWikiTitle() { return $this->wiki_title; }
128128 function getStartTime() { return $this->start_time; }
129129 function setStartTimeNtp($start_time){
130 - $this->start_time = $start_time;
131 - }
132 - function getEndTime() { return $this->end_time; }
 130+ $this->start_time = $start_time;
 131+ }
 132+ function getEndTime() { return $this->end_time; }
133133 function setEndTimeNtp($end_time){
134134 $this->end_time = $end_time;
135135 }
136136 function getTimeRequest() { return $this->start_time . '/' . $this->end_time; }
137137 function getMwTitle() { return Title::MakeTitle( MV_NS_MVD, $this->wiki_title ); }
138 -
 138+
139139 function setStartEndIfEmpty() {
140140 global $mvDefaultStreamViewLength, $wgRequest;
141 - //if overview mode override the time settings:
 141+ //if overview mode override the time settings:
142142 if( $wgRequest->getVal('view') == 'overview' ){
143143 $this->start_time_sec = 0;
144 - $this->start_time = seconds2npt( $this->start_time_sec );
 144+ $this->start_time = seconds2npt( $this->start_time_sec );
145145 $this->end_time_sec = $this->getDuration();
146146 $this->end_time = seconds2npt( $this->end_time_sec );
147147 }
148 -
 148+
149149 if ( $this->start_time == null ) {
150150 $this->start_time_sec = 0;
151 - $this->start_time = seconds2npt( $this->start_time_sec );
 151+ $this->start_time = seconds2npt( $this->start_time_sec );
152152 } else {
153153 $this->start_time_sec = npt2seconds( $this->start_time );
154154 }
@@ -167,7 +167,7 @@
168168 }
169169 }
170170 }
171 - /*
 171+ /*
172172 * returns start time in seconds
173173 */
174174 function getStartTimeSeconds() {
@@ -175,7 +175,7 @@
176176 $this->start_time_sec = npt2seconds( $this->start_time );
177177 return $this->start_time_sec;
178178 }
179 - /*
 179+ /*
180180 * returns end time in seconds
181181 */
182182 function getEndTimeSeconds() {
@@ -187,7 +187,7 @@
188188 return null;
189189 }
190190 /*
191 - * legacy/convenience function (should probably just update all getDuration calls
 191+ * legacy/convenience function (should probably just update all getDuration calls
192192 * to call global MVstream directly
193193 */
194194 function getDuration() {
@@ -205,16 +205,16 @@
206206 */
207207 function getNearStreamName( $range = null, $length = null ) {
208208 global $mvDefaultClipLength, $mvDefaultClipRange;
209 -
 209+
210210 $stream = & mvGetMVStream( $this->stream_name );
211 -
 211+
212212 if ( $range === null )$range = $mvDefaultClipRange;
213 - if ( $length === null )$length = $mvDefaultClipLength;
214 -
 213+ if ( $length === null )$length = $mvDefaultClipLength;
 214+
215215 // subtract $range seconds from the start time:
216216 $start_t = $this->getStartTimeSeconds() - $range;
217217 if ( $start_t < 0 )$start_t = 0;
218 -
 218+
219219 $start_ntp = seconds2npt( $start_t ) ;
220220 // add $range seconds to the end time:
221221 if ( isset( $this->end_time ) ) {
@@ -245,7 +245,7 @@
246246 }
247247 function getFullStreamImageURL( $size = null, $req_time = null, $foce_server = '' ) {
248248 global $wgServer, $mvExternalImages;
249 - // if using external images already:
 249+ // if using external images already:
250250 if ( $mvExternalImages ) {
251251 return $this->getStreamImageURL( $size, $req_time, $foce_server );
252252 } else {
@@ -253,7 +253,7 @@
254254 return $wgServer . $this->getStreamImageURL( $size, $req_time, $foce_server );
255255 }
256256 }
257 - // @@todo force_server is a weird hack ... @@todo remove and update other code locations
 257+ // @@todo force_server is a weird hack ... @@todo remove and update other code locations
258258 function getStreamImageURL( $size = null, $req_time = null, $foce_server = '', $direct_link=false ) {
259259 global $mvDefaultVideoPlaybackRes;
260260 if ( $size == null ) {
@@ -264,14 +264,14 @@
265265 if ( !$req_time )$req_time = '0:00:00';
266266 }
267267 if ( $foce_server == '' ) {
268 - // get the image path: (and generate the image if necessary)
 268+ // get the image path: (and generate the image if necessary)
269269 return MV_StreamImage::getStreamImageURL( $this->getStreamId(), $req_time, $size, $direct_link );
270270 } else {
271271 return $foce_server . $this->getStreamName() . '?t=' . $req_time;
272272 }
273273 }
274274 /* gets all ~direct~ metadata for the current MV_Title
275 - * (does not grab overlapping metadata)
 275+ * (does not grab overlapping metadata)
276276 * (semantic properties and categories)
277277 * */
278278 function getMetaData( $normalized_prop_name = true ) {
@@ -281,7 +281,7 @@
282282 $text = $article->getContent();
283283 // @@todo should use semanticMediaWiki api here
284284 $tmpProp = MV_Overlay::get_and_strip_semantic_tags( $text );
285 - // strip categories
 285+ // strip categories
286286 $retAry['striped_text'] = preg_replace( '/\[\[[^:]+:[^\]]+\]\]/', '', $text );
287287 if ( $normalized_prop_name ) {
288288 foreach ( $tmpProp as $pkey => $pval ) {
@@ -290,9 +290,9 @@
291291 } else {
292292 $retAry['prop'] = $tmpProp;
293293 }
294 -
 294+
295295 $sk =& $wgUser->getSkin();
296 - // run via parser to add in Category info:
 296+ // run via parser to add in Category info:
297297 $parserOptions = ParserOptions::newFromUser( $wgUser );
298298 $parserOutput = $wgParser->parse( $text , $this, $parserOptions );
299299 $retAry['categories'] = $parserOutput->getCategories();
@@ -300,17 +300,17 @@
301301 }
302302 /*
303303 * function: getWebStreamURL
304 - *
 304+ *
305305 * returns full web accessible path to stream
306306 * (by default this is the web streameable version of the file)
307307 * web stream is file_desc_msg as: mv_ogg_low_quality
308308 * $mvDefaultVideoQualityKey in MV_Settings.php
309 - *
 309+ *
310310 */
311311 function getWebStreamURL( $quality = null ) {
312312 global $mvVideoArchivePaths, $mvDefaultVideoQualityKey;
313313 // @@todo mediawiki path for media (instead of hard link to $mvVideoArchive)
314 - // @@todo make sure file exists
 314+ // @@todo make sure file exists
315315 if ( !$quality )$quality = $mvDefaultVideoQualityKey;
316316 if ( $this->doesStreamExist() ) {
317317 // @@todo cache this / have a more organized store for StreamFiles in streamTitle
@@ -321,22 +321,22 @@
322322 ) );
323323 if ( $dbr->numRows( $result ) == 0 )return false;
324324 $streamFile = $dbr->fetchObject( $result );
325 -
326 - // print_r($streamFile);
327 - // make sure we have streamFiles (used to generate the link)
 325+
 326+ // print_r($streamFile);
 327+ // make sure we have streamFiles (used to generate the link)
328328 $mvStreamFile = new MV_StreamFile( $this->mvStream, $streamFile );
329 - // if link empty return false:
 329+ // if link empty return false:
330330 if ( $mvStreamFile->getFullURL() == '' )return false;
331331 $time_req = '';
332332 if ( $this->getStartTime() != '' && $this->getEndTime() != '' ) {
333333 if ( $mvStreamFile->supportsURLTimeEncoding() ) {
334334 if( $mvStreamFile->path_type=='url_anx' )
335335 $time_req = '?t=' . $this->getStartTime() . '/' . $this->getEndTime();
336 -
 336+
337337 if( $mvStreamFile->path_type=='mp4_stream' )
338338 $time_req = '?start=' . $this->getStartTimeSeconds() . '&end=' . $this->getEndTimeSeconds();
339339 }
340 - }
 340+ }
341341 return $mvStreamFile->getFullURL() . $time_req;
342342 } else {
343343 // @@todo throw ERROR
@@ -345,7 +345,7 @@
346346 }
347347 function getROEURL() {
348348 $roeTitle = Title::newFromText( 'MvExportStream', NS_SPECIAL );
349 - // add the query:
 349+ // add the query:
350350 $query = 'stream_name=' . htmlspecialchars( $this->getStreamName() ) .
351351 '&t=' . htmlspecialchars( $this->getTimeRequest() .
352352 '&feed_format=roe' );
@@ -359,7 +359,7 @@
360360 $force_server = (isset($options['force_server']))?$options['force_server']:'';
361361 $autoplay = (isset($options['autoplay']))?$options['autoplay']:false;
362362 $showmeta = (isset($options['showmeta']))?$options['showmeta']:false;
363 -
 363+
364364 $tag = 'video';
365365 if ( $size == '' ) {
366366 global $mvDefaultVideoPlaybackRes;
@@ -368,25 +368,25 @@
369369 } else {
370370 list( $vWidth, $vHeight, $na ) = MV_StreamImage::getSizeType( $size );
371371 }
372 -
373 -
 372+
 373+
374374 $stream_web_url = $this->getWebStreamURL( $mvDefaultVideoQualityKey );
375375 $flash_stream_url = $this->getWebStreamURL( $mvDefaultFlashQualityKey );
376376 $mp4_stream_url = $this->getWebStreamURL( $mvDefaultMP4QualityKey );
377377 // print "looking for q: $mvDefaultFlashQualityKey ";
378378
379 - // print "FOUND: $flash_stream_url";
 379+ // print "FOUND: $flash_stream_url";
380380 $roe_url = $this->getROEURL();
381 - //if no urls available return missing:
 381+ //if no urls available return missing:
382382 if ( !$stream_web_url && !$flash_stream_url && !$mp4_stream_url ) {
383 - return wfMsg( 'mv_error_stream_missing' );
 383+ return wfMsgWikiHtml( 'mv_error_stream_missing' );
384384 }
385 -
 385+
386386 if ( $stream_web_url || $flash_stream_url || $mp4_stream_url) {
387387 $o = '';
388 - /*if($this->dispVideoPlayerTime){
 388+ /*if($this->dispVideoPlayerTime){
389389 $o.='<span id="mv_videoPlayerTime">'.$this->getStartTime().' to '.
390 - htmlspecialchars( $this->getEndTime() ) .
 390+ htmlspecialchars( $this->getEndTime() ) .
391391 '</span>';
392392 }*/
393393 $o .= '<' . htmlspecialchars( $tag ) . ' ';
@@ -394,31 +394,31 @@
395395 $o .= 'poster="' . $this->getStreamImageURL( $size, null, $force_server ) . '" ' .
396396 'roe="' . $roe_url . '" ';
397397 $o .= ($showmeta)?'show_meta_link="true" ':'show_meta_link="false" ' ;
398 -
 398+
399399 $o .= ( $autoplay ) ? ' autoplay="true" ':'';
400 -
 400+
401401 $o .= 'style="width:' . htmlspecialchars( $vWidth ) . 'px;height:' . htmlspecialchars( $vHeight ) . 'px" ' .
402402 'controls="true" embed_link="true" >';
403 -
 403+
404404 if ( $stream_web_url )
405405 $o .= '<source timeFormat="anx" type="' .
406406 htmlspecialchars( MV_StreamFile::getTypeForQK( $mvDefaultVideoQualityKey ) ) .
407407 '" src="' . $stream_web_url . '"></source>';
408 -
 408+
409409 if ( $flash_stream_url )
410410 $o .= '<source timeFormat="anx" type="' .
411411 htmlspecialchars( MV_StreamFile::getTypeForQK( $mvDefaultFlashQualityKey ) ) .
412412 '" src="' . $flash_stream_url . '"></source>';
413 -
 413+
414414 if ( $mp4_stream_url )
415415 $o.='<source timeFormat="mp4" type="' .
416416 htmlspecialchars( MV_StreamFile::getTypeForQK( $mvDefaultMP4QualityKey ) ) .
417417 '" src="' . $mp4_stream_url . '"></source>';
418 -
 418+
419419 $o .= '</' . htmlspecialchars( $tag ) . '>';
420420 return $o;
421 - }
422 - }
 421+ }
 422+ }
423423 function getViewCount() {
424424 if ( $this->view_count == null ) {
425425 $dbr = & wfGetDB( DB_READ );
@@ -446,19 +446,19 @@
447447 return $title_str;
448448 }
449449 /*
450 - * returns a parsed title/request
 450+ * returns a parsed title/request
451451 */
452452 function parseTitle( $title ) {
453453 global $mvDefaultClipLength;
454454 // the metavid namespace:
455455 // stream:stream_name ||
456 - // mvd:type:stream_name_date/start_time/end_time
 456+ // mvd:type:stream_name_date/start_time/end_time
457457
458458 $parts = split( '/', $title );
459459 if ( !isset( $parts[1] ) )$parts[1] = '';
460460 // check for type:
461461 $sub_parts = split( ':', $parts[0] );
462 -
 462+
463463 if ( count( $sub_parts ) == 2 ) {
464464 if ( $sub_parts[0] == '' && $sub_parts[1] == '' ) {
465465 $this->stream_name = null;
@@ -474,7 +474,7 @@
475475 $this->stream_name = null;
476476 } else {
477477 // print_r($sub_parts);
478 - // @@todo do look up of single part request
 478+ // @@todo do look up of single part request
479479 $this->stream_name = $sub_parts[0];
480480 // $this->stream_name = null;
481481 }
@@ -492,28 +492,28 @@
493493 }
494494 }
495495 // (support null endtimes)
496 - // if the endtime is unset set it to the default length after the start time:
 496+ // if the endtime is unset set it to the default length after the start time:
497497 // if(!isset($end_time)){
498498 // $this->end_time = seconds2npt(npt2seconds($this->start_time) + $mvDefaultClipLength) ;
499499 // }
500500
501 - // @@todo make sure start time is not negative & end time is not > duration
 501+ // @@todo make sure start time is not negative & end time is not > duration
502502
503 - // validate the start time:
 503+ // validate the start time:
504504 if ( mvIsNtpTime( $this->start_time ) == false )$this->start_time = null;
505 -
506 - // validate the end time:
 505+
 506+ // validate the end time:
507507 if ( $this->end_time != null ) {
508508 if ( mvIsNtpTime( $this->end_time ) == false )$this->end_time = null;
509 -
510 - // make sure the end time is > than the start time:
 509+
 510+ // make sure the end time is > than the start time:
511511 if ( npt2seconds( $this->start_time ) > npt2seconds( $this->end_time ) ) {
512 - // @@TODO better error handling
 512+ // @@TODO better error handling
513513 $this->start_time = null;
514514 $this->end_time = null;
515515 }
516516 }
517517 }
518 -
 518+
519519 }
520520 ?>
Index: trunk/extensions/MetavidWiki/skins/mv_allpages.js
@@ -5,7 +5,7 @@
66 if( typeof wgServer!='undefined' && typeof wgScript != 'undefined'){
77 var base_roe_url = wgServer + wgScript + '?title=Special:MvExportStream&feed_format=roe&stream_name=';
88 }else{
9 - var base_roe_url='';
 9+ var base_roe_url = '';
1010 }
1111 //force wgScript path for blog support
1212 if(typeof wgScript=='undefined')
Index: trunk/extensions/MetavidWiki/skins/add_media_wizard.OFF.js
@@ -54,7 +54,7 @@
5555 }
5656
5757 //check if we are on a edit page:
58 -if( wgAction == 'edit' || wgAction == 'submit' ){
 58+if( wgAction == 'edit' || wgAction == 'submit' ){
5959 //add onPage ready request:
6060 addOnloadHook( function(){
6161 var imE = document.createElement('img');

Status & tagging log