r52403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52402‎ | r52403 | r52404 >
Date:17:29, 25 June 2009
Author:tparscal
Status:ok
Tags:
Comment:
Corrected vertical alignment of text in navigation tabs
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -556,7 +556,7 @@
557557 <h5><?php $this->msg('namespaces') ?></h5>
558558 <ul <?php $this->html('userlangattributes') ?>>
559559 <?php foreach ($this->data['namespace_urls'] as $key => $link ): ?>
560 - <li <?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
 560+ <li <?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><span><?php echo htmlspecialchars( $link['text'] ) ?></span></a></li>
561561 <?php endforeach; ?>
562562 </ul>
563563 </div>
@@ -583,7 +583,7 @@
584584 <h5><?php $this->msg('views') ?></h5>
585585 <ul <?php $this->html('userlangattributes') ?>>
586586 <?php foreach ($this->data['view_urls'] as $key => $link ): ?>
587 - <li<?php echo $link['attributes'] ?><?php if(!empty($link['class'])): ?> class="<?php echo htmlspecialchars($link['class']) ?>"<?php endif; ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
 587+ <li<?php echo $link['attributes'] ?><?php if(!empty($link['class'])): ?> class="<?php echo htmlspecialchars($link['class']) ?>"<?php endif; ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><span><?php echo htmlspecialchars( $link['text'] ) ?></span></a></li>
588588 <?php endforeach; ?>
589589 </ul>
590590 </div>
Index: trunk/phase3/skins/vector/main.css
@@ -149,7 +149,7 @@
150150 div#namespaces li,
151151 div#views li {
152152 float: left;
153 - line-height: 3em;
 153+ height: 3em;
154154 background-image: url(images/tab-normal-fade.png);
155155 background-position: bottom left;
156156 background-repeat: repeat-x;
@@ -172,20 +172,26 @@
173173 background-image: url(images/tab-break.png);
174174 background-position: bottom right;
175175 background-repeat: no-repeat;
176 - color: #0645ad;
177176 }
178177 body.rtl div#namespaces a,
179178 body.rtl div#views a {
180179 background-position: bottom left;
181180 }
182 - div#namespaces li.selected a,
183 - div#views li.selected a:visited {
 181+ div#namespaces a span,
 182+ div#views a span {
 183+ color: #0645ad;
 184+ display: inline-block;
 185+ padding-top: 1.25em;
 186+ cursor: pointer;
 187+ }
 188+ div#namespaces li.selected a span,
 189+ div#views li.selected a:visited span {
184190 color: #333333;
185191 cursor: default;
186192 text-decoration: none;
187193 }
188 - div#namespaces li.new a,
189 - div#namespaces li.new a:visited{
 194+ div#namespaces li.new a span,
 195+ div#namespaces li.new a:visited span{
190196 color: #a55858;
191197 }
192198 /* Variants and Actions */

Status & tagging log