r52381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52380‎ | r52381 | r52382 >
Date:00:23, 25 June 2009
Author:dale
Status:deferred
Tags:
Comment:
added hint that archive.org supports oggz_chop
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/example_usage/Player_Timed_Text.html (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libTimedText/mvTextInterface.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/example_usage/Player_Timed_Text.html
@@ -21,7 +21,7 @@
2222 <td valign="top" width="410">
2323 <video poster="http://ia340929.us.archive.org/0/items/princess_iron_fan/princess_iron_fan.thumbs/princess_iron_fan_000360.jpg"
2424 duration="1:13:0" linkback="http://www.archive.org/details/princess_iron_fan" >
25 - <source type="video/ogg" src="http://www.archive.org/download/princess_iron_fan/princess_iron_fan.ogv" URLTimeEncoding="true"></source>
 25+ <source type="video/ogg" src="http://www.archive.org/download/princess_iron_fan/princess_iron_fan.ogv" ></source>
2626 <source type="video/h264" src="http://www.archive.org/download/princess_iron_fan/princess_iron_fan_512kb.mp4"></source>
2727 <text category="SUB" lang="en" type="text/x-srt" default="true"
2828 title="English subtitles" src="media/princess_archive_org/princess_iron_fan.srt">
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js
@@ -392,8 +392,7 @@
393393 $j('#mv_play_head_'+embedObj.id + ' .ui-slider-range').addClass('ui-corner-all').css('z-index', 2);
394394 //extended class list for jQuery ui themeing (we can probably refactor this with custom buffering highliter)
395395 $j('#mv_play_head_'+embedObj.id).append( ctrlBuilder.getMvBufferHtml() );
396 -
397 -
 396+
398397 //videoOptions:
399398 $j('#mv_vid_options_'+ctrlBuilder.id+' .vo_selection').click(function(){
400399 embedObj.selectPlaybackMethod();
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js
@@ -84,6 +84,7 @@
8585 this.parent_doSeek(perc);
8686 }
8787 }else if(this.vid && this.vid.duration ){
 88+ //(could also check bufferedPercent > perc seek (and issue oggz_chop request or not)
8889 this.doNativeSeek(perc);
8990 }else{
9091 this.doPlayThenSeek(perc)
@@ -95,7 +96,7 @@
9697 this.parent_monitor();
9798 },
9899 doPlayThenSeek:function(perc){
99 - js_log('doPlayThenSeek Hack');
 100+ js_log('native::doPlayThenSeek::');
100101 var _this = this;
101102 this.play();
102103 var rfsCount = 0;
Index: branches/new-upload/phase3/js2/mwEmbed/libTimedText/mvTextInterface.js
@@ -5,7 +5,6 @@
66 "close" : "close",
77 "improve_transcript" : "Improve",
88 })
9 -
109 // text interface object (for inline display captions)
1110 var mvTextInterface = function( parentEmbed ){
1211 return this.init( parentEmbed );
@@ -180,7 +179,7 @@
181180 _this.pe.highlightPlaySection( {
182181 'start' : $j(this).parent().attr("start"),
183182 'end' : $j(this).parent().attr("end")
184 - });
 183+ });
185184 },
186185 out:function () {
187186 js_log('mvttseek: out');
@@ -288,7 +287,7 @@
289288 }
290289 };
291290 /*js_log('search_for_range:'+search_for_range + ' for: '+ cur_time);*/
292 - if(search_for_range){
 291+ if( search_for_range ){
293292 //search for current time: add tt_scroll_highlight to clip
294293 // optimize:
295294 // should do binnary search not iterative
@@ -516,4 +515,4 @@
517516 }
518517 }
519518 }
520 -};
\ No newline at end of file
 519+};

Status & tagging log