r52366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52365‎ | r52366 | r52367 >
Date:17:24, 24 June 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix summarize links again, and add an intro so people know what they are doing when they click Summarize
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/LqtView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/i18n/Lqt.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/i18n/Lqt.i18n.php
@@ -158,6 +158,8 @@
159159 'lqt-thread-edited-others'=> 'Edited by other users',
160160 'lqt-header-actions' => 'Actions',
161161 'lqt_summarize_link' => 'Summarize',
 162+ 'lqt-summarize-intro' => 'Please summarize the below thread in the editing box.
 163+You may use any wikitext in your summary. When you finish, click "{{int:savearticle}}".',
162164
163165 // Logging
164166 'lqt-log-name' => 'Threaded discussion log',
Index: trunk/extensions/LiquidThreads/classes/LqtView.php
@@ -326,6 +326,7 @@
327327 }
328328
329329 function showSummarizeForm( $thread ) {
 330+ $this->output->addWikiMsg( 'lqt-summarize-intro' );
330331 $this->showEditingFormInGeneral( null, 'summarize', $thread );
331332 }
332333
@@ -570,9 +571,10 @@
571572 'href' => $history_url,
572573 'enabled' => true );
573574
 575+ $summarizeUrl = self::permalinkUrl( $thread, 'summarize', $thread->id() );
574576 $commands['summarize'] = array(
575577 'label' => wfMsgExt( 'lqt_summarize_link', 'parseinline' ),
576 - 'href' => self::permalinkUrl( $thread, 'summarize' ),
 578+ 'href' => $summarizeUrl,
577579 'enabled' => true,
578580 );
579581
@@ -973,7 +975,8 @@
974976 wfLoadExtensionMessages( 'LiquidThreads' );
975977
976978 $permalink_text = wfMsgNoTrans( 'lqt_summary_notice_link' );
977 - $permalink = self::permalink( $thread, $permalink_text, 'summarize' );
 979+ $permalink = self::permalink( $thread, $permalink_text, 'summarize',
 980+ $thread->id() );
978981 $msg = wfMsgExt( 'lqt_summary_notice', array('parseinline', 'replaceafter'),
979982 array( $permalink, $thread->getArchiveStartDays() ) );
980983 $msg = Xml::tags( 'p', array( 'class' => 'lqt_summary_notice' ), $msg );
@@ -1070,7 +1073,7 @@
10711074 $label );
10721075
10731076 $link = $sk->link( $t->summary()->getTitle(), $link_text );
1074 - $edit_link = self::permalink( $t, $edit_text, 'summarize' );
 1077+ $edit_link = self::permalink( $t, $edit_text, 'summarize', $t->id() );
10751078 $links = "[$link]\n[$edit_link]";
10761079 $html .= Xml::tags( 'span', array( 'class' => 'lqt_thread_permalink_summary_edit' ),
10771080 $links );

Status & tagging log