r52359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52358‎ | r52359 | r52360 >
Date:14:44, 24 June 2009
Author:werdna
Status:deferred
Tags:
Comment:
Phase 2 of visual refresh: Mimic comment threads by taking the "nested boxes" approach, rather than ugly indentation
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/LqtView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -264,7 +264,6 @@
265265 }
266266
267267 .lqt_post {
268 - margin-bottom: 2em;
269268 padding: 0;
270269 padding-bottom: 0.5em;
271270 clear: both;
@@ -464,6 +463,7 @@
465464 border-bottom: 1px solid #aaaaaa;
466465 clear: both;
467466 line-height: 2em;
 467+ background-color: #eeeeee;
468468 }
469469
470470 .lqt-thread-header-info > span {
@@ -552,3 +552,10 @@
553553 vertical-align: middle;
554554 padding-bottom: 0.5em;
555555 }
 556+
 557+.lqt_thread {
 558+ border: 1px solid #cccccc;
 559+ padding: 0.2em;
 560+ margin: 0.3em;
 561+ margin-left: 2em;
 562+}
Index: trunk/extensions/LiquidThreads/classes/LqtView.php
@@ -1006,13 +1006,9 @@
10071007 $this->showSingleThread( $thread );
10081008
10091009 if ( $thread->hasSubthreads() ) {
1010 - $this->output->addHTML( $this->indent( $thread ) );
1011 -
10121010 foreach ( $thread->subthreads() as $st ) {
10131011 $this->showThread( $st );
10141012 }
1015 -
1016 - $this->output->addHTML( $this->unindent( $thread ) );
10171013 }
10181014
10191015 $this->output->addHTML( Xml::closeElement( 'div' ) );

Status & tagging log