r52327 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52326‎ | r52327 | r52328 >
Date:22:05, 23 June 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed removed transition export bug
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libAddMedia/mvBaseUploadInterface.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libAddMedia/mvBaseUploadInterface.js
@@ -183,9 +183,8 @@
184184 'comment' : $j('#wpUploadDescription').val()
185185 }
186186 //check for editToken
187 - _this.etoken = $j("input[name='wpEditToken']").val();
188 -
189 - _this.doHttpUpload( httpUpConf );
 187+ _this.etoken = $j("input[name='wpEditToken']").val();
 188+ _this.doHttpUpload( httpUpConf );
190189 }else{
191190 js_error( 'Error: unrecongized upload mode: ' + _this.upload_mode );
192191 }
Index: branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js
@@ -675,12 +675,14 @@
676676 o+="\t<head>\n";
677677 //get transitions
678678 for(var i in this.plObj.transitions){
679 - var tObj = this.plObj.transitions[i].getAttributeObj();
680 - o+="\t\t<transition ";
681 - for(var j in tObj){
682 - o+=' '+j+'="' + tObj[j] + '"\n\t\t';
 679+ if( this.plObj.transitions[i] ){
 680+ var tObj = this.plObj.transitions[i].getAttributeObj();
 681+ o+="\t\t<transition ";
 682+ for(var j in tObj){
 683+ o+=' '+j+'="' + tObj[j] + '"\n\t\t';
 684+ }
 685+ o+='/>'+"\n"; //transitions don't have children
683686 }
684 - o+='/>'+"\n"; //transitions don't have children
685687 }
686688 o+="\t</head>\n";
687689

Status & tagging log