r52304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52303‎ | r52304 | r52305 >
Date:09:58, 23 June 2009
Author:aaron
Status:ok
Tags:
Comment:
Skip form on implicit title diffs (bug 19327)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -820,7 +820,8 @@
821821 }
822822 # Check action and if page is protected
823823 $action = $wgRequest->getVal( 'action', 'view' );
824 - if( !self::isViewAction($action) ) {
 824+ # Must be view/diff action...and title must not be ambiguous
 825+ if( !self::isViewAction($action) || !$wgRequest->getVal('title') ) {
825826 return true;
826827 }
827828 $this->addQuickReview( $data, $wgRequest->getVal('diff'), false );

Status & tagging log