r52300 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52299‎ | r52300 | r52301 >
Date:01:37, 23 June 2009
Author:brion
Status:ok
Tags:
Comment:
Reverting r51209 -- change to German number formatting per bug 18957.
Apparently there is wild disagreement on what the proper formatting is; since no one complained in the previous 8 years I'm returning it to the status quo.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/classes/LanguageDe.php (deleted) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -60,6 +60,7 @@
6161 'Bild_Diskussion' => NS_FILE_TALK,
6262 );
6363
 64+
6465 $bookstoreList = array(
6566 'abebooks.de' => 'http://www.abebooks.de/servlet/BookSearchPL?ph=2&isbn=$1',
6667 'amazon.de' => 'http://www.amazon.de/exec/obidos/ISBN=$1',
@@ -68,11 +69,7 @@
6970 'Lehmanns Fachbuchhandlung' => 'http://www.lob.de/cgi-bin/work/suche?flag=new&stich1=$1'
7071 );
7172
72 -$separatorTransformTable = array(
73 - ',' => "\xc2\xa0", # nbsp
74 - '.' => ','
75 -);
76 -
 73+$separatorTransformTable = array(',' => '.', '.' => ',' );
7774 $linkTrail = '/^([äöüßa-z]+)(.*)$/sDu';
7875
7976 $specialPageAliases = array(
Index: trunk/phase3/languages/classes/LanguageDe.php
@@ -1,21 +0,0 @@
2 -<?php
3 -/** German
4 - *
5 - * @ingroup Language
6 - */
7 -class LanguageDe extends Language {
8 -
9 - /*
10 - * FIXME: Comment is wrong, decimals prevent space suppression
11 - * German numeric format is "12 345,67" but "1234,56"
12 - * Copied from LanguageUk.php
13 - */
14 -
15 - function commafy($_) {
16 - if (!preg_match('/^\d{1,4}$/',$_)) {
17 - return strrev((string)preg_replace('/(\d{3})(?=\d)(?!\d*\.)/','$1,',strrev($_)));
18 - } else {
19 - return $_;
20 - }
21 - }
22 -}
Index: trunk/phase3/RELEASE-NOTES
@@ -253,7 +253,6 @@
254254 * (bug 18806) Use correct unicode characters in spelling of native Chuvash
255255 (Чӑвашла)
256256 * (bug 18864) Updated autonym for Zhuang language
257 -* (bug 18957) Updated number formatting for German (de)
258257 * (bug 18308) Updated date formatting in Occitan (oc)
259258 * (bug 19080) Added ăâîşţșțĂÂÎŞŢȘȚ to Romanion (ro) linktrail
260259 * (bug 19286) Correct commafying function in Polish (pl)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51209(bug 18957) Update number formatting for German. Same behaviour as for Ukrani...siebrand21:00, 30 May 2009

Status & tagging log