r52291 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52290‎ | r52291 | r52292 >
Date:17:46, 22 June 2009
Author:ialex
Status:deferred
Tags:
Comment:
follow-up r52258: change default trust root to "$wgServer . $wgScriptPath" (rather than $wgServer . $wgArticlePath) since we now always use $wgScriptPath for urls
Modified paths:
  • /trunk/extensions/OpenID/SpecialOpenID.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenID.body.php
@@ -171,9 +171,8 @@
172172 if ( !is_null( $wgTrustRoot ) ) {
173173 $trust_root = $wgTrustRoot;
174174 } else {
175 - global $wgArticlePath, $wgServer;
176 - $root_article = str_replace( '$1', '', $wgArticlePath );
177 - $trust_root = $wgServer . $root_article;
 175+ global $wgScriptPath, $wgServer;
 176+ $trust_root = $wgServer . $wgScriptPath;
178177 }
179178
180179 wfSuppressWarnings();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52258PerSergey Chernyshev's comment on r52236 (and fix for that revision): add Spe...ialex21:32, 21 June 2009

Status & tagging log