r52156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52155‎ | r52156 | r52157 >
Date:08:52, 19 June 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
* (bug 19286) Correct commafying function in Polish (pl)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/classes/LanguageDe.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguagePl.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/classes/LanguageDe.php
@@ -6,6 +6,7 @@
77 class LanguageDe extends Language {
88
99 /*
 10+ * FIXME: Comment is wrong, decimals prevent space suppression
1011 * German numeric format is "12 345,67" but "1234,56"
1112 * Copied from LanguageUk.php
1213 */
Index: trunk/phase3/languages/classes/LanguagePl.php
@@ -21,4 +21,12 @@
2222 return $forms[2]; // plural genitive
2323 }
2424 }
 25+
 26+ function commafy($_) {
 27+ if (!preg_match('/^\d{1,4}(.\d+)?$/',$_)) {
 28+ return strrev((string)preg_replace('/(\d{3})(?=\d)(?!\d*\.)/','$1,',strrev($_)));
 29+ } else {
 30+ return $_;
 31+ }
 32+ }
2533 }
Index: trunk/phase3/RELEASE-NOTES
@@ -242,9 +242,10 @@
243243 * (bug 18806) Use correct unicode characters in spelling of native Chuvash
244244 (Чӑвашла)
245245 * (bug 18864) Updated autonym for Zhuang language
246 -* (bug 18957) Updated number formatting for German
247 -* (bug 18308) Updated date formatting in Occitan
 246+* (bug 18957) Updated number formatting for German (de)
 247+* (bug 18308) Updated date formatting in Occitan (oc)
248248 * (bug 19080) Added ăâîşţșțĂÂÎŞŢȘȚ to Romanion (ro) linktrail
 249+* (bug 19286) Correct commafying function in Polish (pl)
249250
250251 == Compatibility ==
251252

Status & tagging log