r52119 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52118‎ | r52119 | r52120 >
Date:15:19, 18 June 2009
Author:vasilievvv
Status:deferred
Tags:
Comment:
Fix SQL error on sorting filters by status
Modified paths:
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php
@@ -178,7 +178,7 @@
179179 'af_id' => 'abusefilter-list-id',
180180 'af_public_comments' => 'abusefilter-list-public',
181181 'af_actions' => 'abusefilter-list-consequences',
182 - 'status' => 'abusefilter-list-status',
 182+ 'af_enabled' => 'abusefilter-list-status',
183183 'af_timestamp' => 'abusefilter-list-lastmodified',
184184 'af_hidden' => 'abusefilter-list-visibility',
185185 'af_hit_count' => 'abusefilter-list-hitcount' );
@@ -216,7 +216,7 @@
217217 $displayActions[] = AbuseFilter::getActionDisplay( $action );;
218218 }
219219 return htmlspecialchars( implode( ', ', $displayActions ) );
220 - case 'status':
 220+ case 'af_enabled':
221221 $statuses = array();
222222 if ($row->af_deleted)
223223 $statuses[] = wfMsgExt( 'abusefilter-deleted', 'parseinline' );
@@ -287,7 +287,7 @@
288288 function isFieldSortable($name) {
289289 $sortable_fields = array(
290290 'af_id',
291 - 'status',
 291+ 'af_enabled',
292292 'af_hit_count',
293293 'af_throttled',
294294 'af_user_text',

Status & tagging log