r52115 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52114‎ | r52115 | r52116 >
Date:14:00, 18 June 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
Move the checker to correct class, from aliases to mw extensions
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -377,6 +377,21 @@
378378 public function exists() {
379379 return is_readable( $this->getMessageFileWithPath( 'en' ) );
380380 }
 381+
 382+ public function getChecker() {
 383+ $checker = new MediaWikiMessageChecker( $this );
 384+ $checker->setChecks( array(
 385+ array( $checker, 'pluralCheck' ),
 386+ array( $checker, 'wikiParameterCheck' ),
 387+ array( $checker, 'wikiLinksCheck' ),
 388+ array( $checker, 'XhtmlCheck' ),
 389+ array( $checker, 'braceBalanceCheck' ),
 390+ array( $checker, 'pagenameMessagesCheck' ),
 391+ array( $checker, 'miscMWChecks' )
 392+ ) );
 393+ return $checker;
 394+ }
 395+
381396 }
382397
383398 class AliasMessageGroup extends ExtensionMessageGroup {
@@ -438,20 +453,6 @@
439454 $writer->commaToArray = true;
440455 return $writer;
441456 }
442 -
443 - public function getChecker() {
444 - $checker = new MediaWikiMessageChecker( $this );
445 - $checker->setChecks( array(
446 - array( $checker, 'pluralCheck' ),
447 - array( $checker, 'wikiParameterCheck' ),
448 - array( $checker, 'wikiLinksCheck' ),
449 - array( $checker, 'XhtmlCheck' ),
450 - array( $checker, 'braceBalanceCheck' ),
451 - array( $checker, 'pagenameMessagesCheck' ),
452 - array( $checker, 'miscMWChecks' )
453 - ) );
454 - return $checker;
455 - }
456457 }
457458
458459 class CoreMostUsedMessageGroup extends CoreMessageGroup {

Status & tagging log