r52076 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52075‎ | r52076 | r52077 >
Date:21:16, 17 June 2009
Author:ialex
Status:deferred
Tags:
Comment:
fix some E_PARSE, seems that PHP doesn't like new Class()->someMethod();
Modified paths:
  • /trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php
@@ -208,7 +208,8 @@
209209 }
210210
211211 // Get the array with messages
212 - $vars = new ConfEditor( $basefilecontents )->getVars();
 212+ $fileEditor = new ConfEditor( $basefilecontents );
 213+ $vars = $fileEditor->getVars();
213214 $base_messages = $vars['base_messages'];
214215
215216 $comparefilecontents = self::getFileContents( $comparefile );
@@ -229,7 +230,8 @@
230231 }
231232 }
232233 // Get the array
233 - $vars = new ConfEditor( $comparefilecontents )->getVars();
 234+ $fileEditor = new ConfEditor( $comparefilecontents );
 235+ $vars = $fileEditor->getVars();
234236 $compare_messages = $vars['compare_messages'];
235237
236238 // if the localfile and the remote file are the same, skip them!
@@ -375,7 +377,8 @@
376378 }
377379
378380 // And get the real contents
379 - $vars = new ConfEditor( $basefilecontents )->getVars();
 381+ $fileEditor = new ConfEditor( $basefilecontents );
 382+ $vars = $fileEditor->getVars();
380383 $base_messages = $vars['base_messages'];
381384
382385 $comparefilecontents = self::getFileContents( $comparefile );
@@ -395,7 +398,8 @@
396399 }
397400 }
398401 // Get the real array
399 - $vars = new ConfEditor( $comparefilecontents )->getVars();
 402+ $fileEditor = new ConfEditor( $comparefilecontents );
 403+ $vars = $fileEditor->getVars();
400404 $compare_messages = $vars['compare_messages'];
401405
402406 // If both files are the same, they can be skipped

Status & tagging log