r52067 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52066‎ | r52067 | r52068 >
Date:19:00, 17 June 2009
Author:tparscal
Status:ok
Tags:
Comment:
Some CSS fixes to avoid overriding where it shouldn't be
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -137,9 +137,9 @@
138138 padding-left: 0.25em;
139139 }
140140 .mw-search-formheader div.search-types > ul {
141 - margin: 0;
142 - padding: 0;
143 - list-style: none;
 141+ margin: 0 !important;
 142+ padding: 0 !important;
 143+ list-style: none !important;
144144 }
145145 .mw-search-formheader div.search-types > ul > li {
146146 float: left;
@@ -174,15 +174,14 @@
175175 }
176176 fieldset#mw-searchoptions {
177177 margin: 0;
178 - padding: 0;
179 - padding-left: 1em;
180 - padding-right: 1em;
181 - padding-bottom: 0.5em;
182 - padding-top: 0.5em;
 178+ padding-left: 0.75em !important;
 179+ padding-right: 0.75em !important;
 180+ padding-bottom: 0.5em !important;
 181+ padding-top: 0.5em !important;
183182 border: none;
184183 background-color: #f9f9f9;
185 - border: 1px solid silver;
186 - border-top: none;
 184+ border: 1px solid silver !important;
 185+ border-top: none !important;
187186 }
188187 fieldset#mw-searchoptions > legend {
189188 display: none;
Index: trunk/phase3/skins/Vector.php
@@ -35,10 +35,10 @@
3636 * @param object $out Output page to add styles to
3737 */
3838 public function setupSkinUserCss( OutputPage $out ) {
39 - parent::setupSkinUserCss( $out );
40 -
4139 // Append to the default screen common & print styles...
4240 $out->addStyle( 'vector/main.css', 'screen' );
 41+ // Add common styles
 42+ parent::setupSkinUserCss( $out );
4343 }
4444
4545 /**

Status & tagging log