r52020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52019‎ | r52020 | r52021 >
Date:06:18, 17 June 2009
Author:dale
Status:deferred
Tags:
Comment:
removed extra debug call
Modified paths:
  • /branches/new-upload/phase3/js2/editPage.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libAddMedia/remoteSearchDriver.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css (modified) (history)
  • /branches/new-upload/phase3/js2/remoteMwEmbed.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libAddMedia/remoteSearchDriver.js
@@ -339,7 +339,7 @@
340340
341341 //set up the target invocation:
342342 if( $j(this.target_invocation).length==0 ){
343 - js_error("RemoteSearchDriver:: no target invocation provided")
 343+ js_log("RemoteSearchDriver:: no target invocation provided")
344344 }else{
345345 $j(this.target_invocation).css('cursor','pointer').attr('title', gM('add_media_wizard')).click(function(){
346346 _this.doInitDisplay();
Index: branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css
@@ -702,7 +702,6 @@
703703
704704
705705
706 -
707706 /* jCROP css:*/
708707 .jcrop-holder
709708 {
Index: branches/new-upload/phase3/js2/remoteMwEmbed.js
@@ -23,9 +23,10 @@
2424 }
2525
2626 //oggHandler rewrite:
 27+var vidIdList = [];
2728 var divs = document.getElementsByTagName('div');
2829 for(var i = 0; i < divs.length; i++){
29 - if( divs[i].id.substring(0,11) == 'ogg_player_'){
 30+ if( divs[i].id && divs[i].id.substring(0,11) == 'ogg_player_'){
3031 vidIdList.push( divs[i].getAttribute("id") );
3132 }
3233 }
Index: branches/new-upload/phase3/js2/editPage.js
@@ -24,8 +24,7 @@
2525 });
2626 var mwEditPageHelper = {
2727 init:function(){
28 - var _this = this;
29 - alert('runing mwEditPageHelper');
 28+ var _this = this;
3029 //add the add-media-wizard button
3130 $j('#toolbar').append('<img style="cursor:pointer" id="btn-add-media-wiz" src="' + mv_skin_img_path + 'Button_add_media.png">');
3231 $j('#btn-add-media-wiz').addMediaWiz(

Status & tagging log