r52014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52013‎ | r52014 | r52015 >
Date:23:41, 16 June 2009
Author:dale
Status:deferred
Tags:
Comment:
other minor fixes
Modified paths:
  • /branches/new-upload/phase3/extensions (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js (modified) (history)
  • /branches/new-upload/phase3/skins (modified) (history)

Diff [purge]

Property changes on: branches/new-upload/phase3/skins
___________________________________________________________________
Name: svn:ignore
11 + mvpcf
mvpcf.deps.php
mvpcf.php
Property changes on: branches/new-upload/phase3/extensions
___________________________________________________________________
Name: svn:ignore
22 - SemanticMediaWiki
ExternalData
Gadgets
MetavidWiki
OggHandler
33 + SemanticMediaWiki
ExternalData
Gadgets
MetavidWiki
OggHandler
ParserFunctions
UsabilityInitiative
skins
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js
@@ -30,18 +30,18 @@
3131 'id="' + this.pid + '" ' +
3232 'style="width:' + this.width+'px;height:' + this.height + 'px;" ' +
3333 'width="' + this.width + '" height="'+this.height+'" '+
34 - 'src="' + this.getSrc() + '" >';
 34+ 'src="' + this.getSrc() + '" ';
3535
3636 /*if(!this.onlyLoadFlag)
3737 eb+='autoplay="true" ';*/
3838
3939 //continue with the other attr:
40 - /*eb+= 'oncanplaythrough="$j(\'#'+this.id+'\').get(0).oncanplaythrough();return false;" ' +
 40+ eb+= 'oncanplaythrough="$j(\'#'+this.id+'\').get(0).oncanplaythrough();return false;" ' +
4141 'onloadedmetadata="$j(\'#'+this.id+'\').get(0).onloadedmetadata();return false;" ' +
4242 'loadedmetadata="$j(\'#'+this.id+'\').get(0).onloadedmetadata();return false;" ' +
4343 'onprogress="$j(\'#'+this.id+'\').get(0).onprogress( event );return false;" '+
44 - 'onended="$j(\'#'+this.id+'\').get(0).onended();return false;" >' +*/
45 - eb+='</video>';
 44+ 'onended="$j(\'#'+this.id+'\').get(0).onended();return false;" >' +
 45+ '</video>';
4646 return eb;
4747 },
4848 //@@todo : loading progress

Status & tagging log