r52004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52003‎ | r52004 | r52005 >
Date:21:13, 16 June 2009
Author:catrope
Status:deferred
Tags:
Comment:
OptIn: Make optin-needlogin message nicer per Siebrand's request
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
@@ -18,13 +18,9 @@
1919 $wgOut->setPageTitle( wfMsg( 'optin-title' ) );
2020
2121 if ( $wgUser->isAnon() ) {
22 - $llink = $wgUser->getSkin()->link(
23 - SpecialPage::getTitleFor( 'Userlogin' ),
24 - wfMsgHtml( 'loginreqlink' ),
25 - array(),
26 - array( 'returnto' => $this->getTitle()->getPrefixedUrl() )
27 - );
28 - $wgOut->addHTML( wfMsgWikiHtml( 'optin-needlogin', $llink ) );
 22+ $url = SpecialPage::getTitleFor( 'Userlogin' )->getFullURL(
 23+ array( 'returnto' => $this->getTitle()->getPrefixedUrl() ) );
 24+ $wgOut->addWikiText( wfMsg( 'optin-needlogin', $url ) );
2925 return;
3026 }
3127
Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php
@@ -15,7 +15,7 @@
1616 'optin' => 'OptIn',
1717 'optin-desc' => 'Allow users to opt-in to the Usability Initiative\'s usability enhancements',
1818 'optin-title' => 'Usability Intitiative enhancements',
19 - 'optin-needlogin' => 'You need to $1 to opt-in to the Usability Initiative\'s usability enhancements.',
 19+ 'optin-needlogin' => '<div class="plainlinks">You need to [$1 log in] to opt-in to the Usability Initiative\'s usability enhancements.</div>',
2020 'optin-intro' => 'The Wikipedia Usability Initiative has developed a new skin and a new edit toolbar intended to enhance the usability of Wikipedia. These enhancements have not been enabled for all users yet, but you can opt-in to them by clicking the button below.',
2121 'optin-success-in' => 'You have successfully opted in to the Usability Initiative\'s usability enhancements. You can opt back out at any time by clicking the button below.',
2222 'optin-success-out' => 'You have successfully opted out of the Usability Initiative\'s usability enhancements. You can opt back in at any time by clicking the button below.',

Status & tagging log