r51956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51955‎ | r51956 | r51957 >
Date:10:26, 16 June 2009
Author:simetrical
Status:ok
Tags:
Comment:
Show right logs when viewing/creating deleted page

Patch by Church of Emacs (bug 16950) with whitespace fixes. r51041
tried to remove just rev_deleted log entries from displaying (bug
18747), but removed all entries other than page deletion instead
(including restoration and move logs). It also only removed rev_deleted
log entries for recreating, not just viewing.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1078,7 +1078,8 @@
10791079 protected function showLogs() {
10801080 global $wgUser, $wgOut;
10811081 $loglist = new LogEventsList( $wgUser->getSkin(), $wgOut );
1082 - $pager = new LogPager( $loglist, array('move', 'delete'), false, $this->mTitle->getPrefixedText() );
 1082+ $pager = new LogPager( $loglist, array('move', 'delete'), false,
 1083+ $this->mTitle->getPrefixedText(), '', array( "log_action != 'revision'" ) );
10831084 if( $pager->getNumRows() > 0 ) {
10841085 $pager->mLimit = 10;
10851086 $wgOut->addHTML( '<div class="mw-warning-with-logexcerpt">' );
Index: trunk/phase3/includes/EditPage.php
@@ -2465,7 +2465,8 @@
24662466 global $wgUser;
24672467 $loglist = new LogEventsList( $wgUser->getSkin(), $out );
24682468 $pager = new LogPager( $loglist, array('move', 'delete'), false,
2469 - $this->mTitle->getPrefixedText(), '', array('log_action'=>'delete') );
 2469+ $this->mTitle->getPrefixedText(), '', array( "log_action != 'revision'" ) );
 2470+
24702471 $count = $pager->getNumRows();
24712472 if ( $count > 0 ) {
24722473 $pager->mLimit = 10;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49821(bug 16950) Show move log when recreating a page...simetrical17:20, 24 April 2009
r51041(bug 18747) Show only page deletion log extracts, not revisiondelete onesaaron02:19, 27 May 2009

Status & tagging log