r51951 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51950‎ | r51951 | r51952 >
Date:09:24, 16 June 2009
Author:kim
Status:deferred
Tags:
Comment:
Found 2 more Base_Exception.message references.
Removed/replaced
Modified paths:
  • /trunk/testing/installer/combined_installer.py (modified) (history)

Diff [purge]

Index: trunk/testing/installer/combined_installer.py
@@ -128,7 +128,7 @@
129129 if system.install(installer_name):
130130 return True
131131 except Exception,e: #TODO sometimes an installer may recognise that something CAN NOT be installed, in that case, we should stop trying.
132 - messages.append(system.system_name+": "+e.message)
 132+ messages.append(system.system_name+": "+str(e))
133133
134134 if messages:
135135 raise Combined_Installer_Exception ("\n".join(messages))
@@ -159,7 +159,7 @@
160160 if system.uninstall(installer_name):
161161 return True
162162 except Exception,e: #TODO sometimes an installer may recognise that something CAN NOT be uninstalled, in that case, we should stop trying
163 - messages.append(system.system_name+": "+e.message)
 163+ messages.append(system.system_name+": "+str(e))
164164
165165 if messages:
166166 raise Combined_Installer_Exception ("\n".join(messages))

Status & tagging log