r51920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51919‎ | r51920 | r51921 >
Date:20:08, 15 June 2009
Author:aaron
Status:ok
Tags:
Comment:
reverted r49889 - breaks patrol mark functions (and a real fix was used anyway)
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1705,6 +1705,7 @@
17061706 $dbw->rollback();
17071707 } else {
17081708 global $wgUseRCPatrol;
 1709+ wfRunHooks( 'NewRevisionFromEditComplete', array($this, $revision, $baseRevId, $user) );
17091710 # Update recentchanges
17101711 if( !( $flags & EDIT_SUPPRESS_RC ) ) {
17111712 # Mark as patrolled if the user can do so
@@ -1719,8 +1720,6 @@
17201721 PatrolLog::record( $rc, true );
17211722 }
17221723 }
1723 - # Notify extensions of a new edit
1724 - wfRunHooks( 'NewRevisionFromEditComplete', array(&$this, $revision, $baseRevId, $user) );
17251724 $user->incEditCount();
17261725 $dbw->commit();
17271726 }
@@ -1787,6 +1786,7 @@
17881787 # Update the page record with revision data
17891788 $this->updateRevisionOn( $dbw, $revision, 0 );
17901789
 1790+ wfRunHooks( 'NewRevisionFromEditComplete', array($this, $revision, false, $user) );
17911791 # Update recentchanges
17921792 if( !( $flags & EDIT_SUPPRESS_RC ) ) {
17931793 global $wgUseRCPatrol, $wgUseNPPatrol;
@@ -1800,8 +1800,6 @@
18011801 PatrolLog::record( $rc, true );
18021802 }
18031803 }
1804 - # Notify extensions of a new page edit
1805 - wfRunHooks( 'NewRevisionFromEditComplete', array(&$this, $revision, false, $user) );
18061804 $user->incEditCount();
18071805 $dbw->commit();
18081806

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49889Tweak for bug 17275: reduce autoreview transaction time by moving hook after ...aaron01:00, 26 April 2009

Status & tagging log