r51914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51913‎ | r51914 | r51915 >
Date:17:57, 15 June 2009
Author:siebrand
Status:ok
Tags:
Comment:
(bug 19211) Fix regression from r50351 that caused looping in previous/next navigation
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -464,22 +464,24 @@
465465
466466 $prevLink = wfMsgExt( 'prevn', array( 'escape', 'parsemag' ), $limitText );
467467 if( $first != '' ) {
468 - $query['until'] = $first;
 468+ $prevQuery = $query;
 469+ $prevQuery['until'] = $first;
469470 $prevLink = $sk->link(
470471 $title,
471472 $prevLink,
472473 array(),
473 - $query
 474+ $prevQuery
474475 );
475476 }
476477 $nextLink = wfMsgExt( 'nextn', array( 'escape', 'parsemag' ), $limitText );
477478 if( $last != '' ) {
478 - $query['from'] = $last;
 479+ $lastQuery = $query;
 480+ $lastQuery['from'] = $last;
479481 $nextLink = $sk->link(
480482 $title,
481483 $nextLink,
482484 array(),
483 - $query
 485+ $lastQuery
484486 );
485487 }
486488

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50351Use link() instead of deprecated makeLinkObj() where possible.siebrand23:24, 8 May 2009

Status & tagging log