r51861 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51860‎ | r51861 | r51862 >
Date:06:36, 15 June 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Fixed some syntax errors:
* __call can't be static
* missing comma
* No such thing as "abstract static"
* __set can't be protected
Modified paths:
  • /trunk/extensions/DataCenter/DataCenter.ui.php (modified) (history)
  • /trunk/extensions/GetFamily/GetFamily.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php (modified) (history)
  • /trunk/extensions/examples/ErrorPage/NiceErrorPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/examples/ErrorPage/NiceErrorPage.php
@@ -52,9 +52,4 @@
5353 );
5454 return $a;
5555 }
56 -
57 - static function __call( $method, $args ) {
58 - $name = str_replace( 'OP', '', $method );
59 - return $this->$name( $args[0] );
60 - }
61 -}
\ No newline at end of file
 56+}
Index: trunk/extensions/GetFamily/GetFamily.php
@@ -24,7 +24,7 @@
2525 'version' => '1.0.1',
2626 'author' => 'Łukasz Matysiak',
2727 'description' => 'Generates a family file for pywikipediabot',
28 - 'descriptionmsg' => 'getfamily-desc'
 28+ 'descriptionmsg' => 'getfamily-desc',
2929 'url' => 'http://www.mediawiki.org/wiki/Extension:GetFamily'
3030 );
3131
Index: trunk/extensions/DataCenter/DataCenter.ui.php
@@ -739,9 +739,9 @@
740740 * Abstract function for rendering the input
741741 * @param parameters Array of parameters
742742 */
743 - abstract public static function render(
 743+ public static function render(
744744 array $parameters
745 - );
 745+ ) {}
746746
747747 /* Protected Static Functions */
748748
Index: trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php
@@ -316,7 +316,7 @@
317317 $t->in_setup=False;
318318 }
319319
320 - protected function __set($key,$value) {
 320+ public function __set($key,$value) {
321321 if (!$this->setup())
322322 throw new Exception("OmegaWikiAttributes accessed, but was not properly initialized");
323323 $attributes=&$this->attributes;

Status & tagging log