r51855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51854‎ | r51855 | r51856 >
Date:19:30, 14 June 2009
Author:dale
Status:deferred
Tags:
Comment:
* sequence fixes
* style updates
* 'about sequencer' line added
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libClipEdit/mvClipEdit.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js
@@ -5,10 +5,9 @@
66 * for more info visit http://metavid.org/wiki/Code
77 *
88 * @author Michael Dale
9 - * @email dale@ucsc.edu
10 - * @url http://metavid.org
 9+ * @email mdale@wikimedia.org
1110 *
12 - * @further developed in open source collaboration with kaltura.
 11+ * further developed in open source development partnership with kaltura.
1312 * more info at http://kaltura.com & http://kaltura.org
1413 *
1514 * mv_sequencer.js
@@ -19,7 +18,7 @@
2019 * exports back out to json or inline format
2120 */
2221
23 -loadGM( {
 22+loadGM({
2423 "menu_clipedit" : "Edit Selected Resource",
2524 "menu_cliplib" : "Add Resource",
2625 "menu_transition" : "Transitions Effects",
@@ -117,7 +116,11 @@
118117 edit_stack:new Array(),
119118 disp_menu_item:null,
120119 //trackObj used to payload playlist Track Object (when inline not present)
121 - tracks:{}
 120+ tracks:{},
 121+
 122+ about_html:'Developed by <a href="http://kaltura.com">Kaltura, Inc.</a>' +
 123+ 'in partnership with the <a href="http://wikimediafoundation.org/wiki/Home">Wikimedia Foundation</a> ' +
 124+ '( <a href="#">more info</a> )'
122125 }
123126 var mvSequencer = function(iObj) {
124127 return this.init(iObj);
@@ -230,6 +233,9 @@
231234 'left:5px;bottom:0px;height:25px;">'+
232235 gM('loading_user_rights') +
233236 '</div>'+
 237+ '<div class="about_editor" style="position:absolute;right:5px;bottom:7px;">' +
 238+ this.about_html +
 239+ '</div>'+
234240 '<div id="'+this.sequence_tools_id+'" style="position:absolute;' +
235241 'left:0px;right:'+(this.video_width+15)+'px;top:0px;height:'+(this.video_height+23)+'px;"/>'
236242 );
@@ -269,8 +275,8 @@
270276 var _this = this;
271277 if( this.sequenceEditToken ){
272278 $j(this.target_sequence_container+' .seq_save_cancel').html(
273 - $j.btnHtml( gM('edit_cancel'), 'seq_edit_cancel', 'close') + ' ' +
274 - $j.btnHtml( gM('edit_save'), 'seq_edit_save', 'close')
 279+ $j.btnHtml( gM('edit_save'), 'seq_edit_save', 'close') + ' ' +
 280+ $j.btnHtml( gM('edit_cancel'), 'seq_edit_cancel', 'close')
275281 );
276282 }else{
277283 $j(this.target_sequence_container+' .seq_save_cancel').html( cancel_button + gM('no_edit_permissions') );
@@ -325,13 +331,13 @@
326332 $j('#seq_save_dialog').html( gM('save_done') );
327333 $j('#seq_save_dialog').dialog('option',
328334 'buttons', {
329 - "Done":function(){
330 - //close the editor if we can
331 - $j(this).dialog("close");
 335+ "Done":function(){
 336+ //refresh the page?
 337+ window.location.reload();
332338 },
333339 "Do More Edits": function() {
334340 $j(this).dialog("close");
335 - }
 341+ }
336342 });
337343 });
338344 },
@@ -625,7 +631,7 @@
626632 this.doFocusBindings();
627633
628634 //set up key bidnings
629 - $j().keydown(function(e){
 635+ $j(window).keydown(function(e){
630636 js_log('pushed down on:' + e.which);
631637 if( e.which == 16 )
632638 _this.key_shift_down = true;
@@ -644,7 +650,7 @@
645651 _this.pasteClipBoardClips();
646652
647653 });
648 - $j().keyup(function(e){
 654+ $j(window).keyup(function(e){
649655 js_log('key up on ' + e.which);
650656 //user let go of "shift" turn off multi-select
651657 if( e.which == 16 )
@@ -1030,18 +1036,19 @@
10311037 'time':0
10321038 });
10331039 //render out edit button
1034 - track_html+='<div class="clip_edit_button clip_edit_base clip_control"/>';
 1040+ /*track_html+='<div class="clip_edit_button clip_edit_base clip_control"/>';*/
10351041
10361042 //render out transition edit box
10371043 track_html+='<div id="tb_' + base_id + '" style="" class="clip_trans_box"/>';
10381044
10391045 //render out adjustment text
1040 - track_html+='<div id="' + base_id + '_adj' + '" class="mv_adj_text" style="top:'+ (this.track_clipThumb_height+10 )+'px;">'+
 1046+ /*track_html+='<div id="' + base_id + '_adj' + '" class="mv_adj_text" style="top:'+ (this.track_clipThumb_height+10 )+'px;">'+
10411047 '<span class="mv_adjust_click" onClick="'+this.instance_name+'.adjClipDur(' + track_id + ',' + j + ',\'-\')" /> - </span>'+
10421048 ( (clip.getDuration() > 60 )? seconds2npt(clip.getDuration()): clip.getDuration() ) +
10431049 '<span class="mv_adjust_click" onClick="'+this.instance_name+'.adjClipDur(' + track_id + ',' + j + ',\'+\')" /> + </span>'+
1044 - '</div>';
1045 - track_html+='</span>';
 1050+ '</div>';
 1051+ */
 1052+ track_html+='</span>';
10461053
10471054 }
10481055 //do timeline_mode rendering:
Index: branches/new-upload/phase3/js2/mwEmbed/libClipEdit/mvClipEdit.js
@@ -205,7 +205,9 @@
206206 $j(target).html ( o );
207207 //add update bindings
208208 $j(target + ' .ic_tparam').change(function(){
209 - js_log("updated tparam" + $j(this).attr("name"));
 209+ js_log("updated tparam::" + $j(this).attr("name"));
 210+ //add wait
 211+ //re-parse template
210212 })
211213
212214 //update doFocusBindings
Index: branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css
@@ -698,4 +698,4 @@
699699
700700 .ui-dialog .ui-dialog-buttonpane button { float: left !important; }
701701
702 -
 702+.ui-widget-content a { text-decoration: underline; }

Status & tagging log