r51776 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51775‎ | r51776 | r51777 >
Date:01:47, 12 June 2009
Author:dale
Status:deferred
Tags:
Comment:
seek tweeks
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/mv_embed.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js
@@ -783,7 +783,7 @@
784784 closeModEditor:function(){
785785 //unset the sequencer
786786 _global['mvSeq'] = null;
787 - $j('#modalbox,#mv_overlay').remove();
 787+ $j('#sequencer_target,.ui-widget-overlay').remove();
788788 },
789789 closeModWindow:function(){
790790 $j('#modal_window').hide();
Index: branches/new-upload/phase3/js2/mwEmbed/mv_embed.js
@@ -912,7 +912,11 @@
913913 }else{
914914 seconds = Math.round( seconds );
915915 }
916 -
 916+ if(seconds <10 )
 917+ seconds = '0'+ seconds;
 918+ if(minutes < 10 )
 919+ minutes = '0' + minutes;
 920+
917921 return hours+":"+minutes+":"+seconds;
918922 }
919923 /*
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js
@@ -237,7 +237,7 @@
238238 },
239239 //this should not be needed.
240240 checkClipsReady : function(){
241 - js_log('checkClipsReady');
 241+ //js_log('checkClipsReady');
242242 var is_ready=true;
243243 for(var i=0; i < global_player_list.length; i++){
244244 if( $j('#'+global_player_list[i]).length !=0){
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js
@@ -72,7 +72,7 @@
7373 //@@todo check if the clip is loaded here (if so we can do a local seek)
7474 if( this.supportsURLTimeEncoding() || !this.vid){
7575 //make sure we could not do a local seek instead:
76 - if( perc < this.bufferedPercent ){
 76+ if( perc < this.bufferedPercent && this.vid.duration ){
7777 js_log("do local seek " + perc + ' is already buffered < ' + this.bufferedPercent);
7878 this.doNativeSeek(perc);
7979 }else{

Status & tagging log