r51754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51753‎ | r51754 | r51755 >
Date:19:41, 11 June 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed a few CSS bugs and tweked some javascript field names.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css
@@ -9,13 +9,13 @@
1010 textarea#wpTextbox1 {
1111 border: solid silver 1px;
1212 padding: 0;
13 - margin-top: -2px;
 13+ margin: 0;
1414 }
1515 /* ... */
1616 div#edittoolbar {
1717 border: solid silver 1px;
1818 border-bottom-width: 0;
19 - background-color: #EEEEEE;
 19+ background-color: #F3F3F3;
2020 }
2121 div#edittoolbar div.tabs,
2222 div#edittoolbar div.group {
@@ -91,6 +91,7 @@
9292 }
9393 body.rtl div#edittoolbar div.group > select {
9494 float: right;
 95+ font-size: 0.9em;
9596 }
9697 div#edittoolbar div.index {
9798 float: left;
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -266,14 +266,6 @@
267267 .appendTo( pageDiv );
268268 for ( character in section.pages[page].characters ) {
269269 switch( section.pages[page].characters[character].type ) {
270 - case 'break':
271 - /*
272 - pageDiv.append(
273 - $( '<div />' )
274 - .css( 'clear', 'both' )
275 - );
276 - */
277 - break;
278270 case 'link':
279271 var context = {
280272 'tool' : section.pages[page].characters[character],
@@ -282,7 +274,7 @@
283275 charsDiv.append(
284276 $( '<a />' )
285277 .attr( 'href', '#' )
286 - .text( section.pages[page].characters[character].text )
 278+ .text( section.pages[page].characters[character].label )
287279 .data( 'context', context)
288280 .click( action )
289281 .click( function() { return false; } )
@@ -363,7 +355,7 @@
364356 for( character in charinsert[page][line] ) {
365357 var tool = {
366358 type: 'link',
367 - text: '',
 359+ label: '',
368360 action: {
369361 type: 'encapsulate',
370362 options: {
@@ -378,10 +370,9 @@
379371 } else {
380372 tool.action.options.pre = charinsert[page][line][character];
381373 }
382 - tool.text = tool.action.options.pre + tool.action.options.post;
 374+ tool.label = tool.action.options.pre + tool.action.options.post;
383375 characters[i++] = tool;
384376 }
385 - characters[i++] = { type: 'break' };
386377 }
387378 retval[pageKey] = {
388379 label: page,

Status & tagging log