r51674 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51673‎ | r51674 | r51675 >
Date:01:51, 10 June 2009
Author:dale
Status:deferred
Tags:
Comment:
sequencer style updates
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libClipEdit/mvClipEdit.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvPlayList.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/mv_embed.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvPlayList.js
@@ -116,21 +116,35 @@
117117 //pulls up the video editor inline
118118 doEditor:function(){
119119 //black out the page:
120 - $j('body').append('<div id="modalbox" class="modal_editor">' + '<div id="mv_overlay"/> ');
121 -
122 - $j('#modalbox').html('loading editor<blink>...</blink>');
123 - var _this=this;
124 - js_log("calling sequence with url:" + _this.src);
 120+ //$j('body').append('<div id="ui-widget-overlay"/> <div id="modalbox" class="ui-widget ui-widget-content ui-corner-all modal_editor">' );
125121
126 - //clone the playlist (to make for easy cancel)
 122+ $j('body').append('<div id="sequencer_target" style="position:aboslute;top:10px;left:10px;right:10px;bottom:10px" title="' + gM('loading_title') + '" ></div>');
 123+ $j('#sequencer_target').dialog({
 124+ bgiframe: true,
 125+ autoOpen: true,
 126+ modal: true,
 127+ buttons: {
 128+ 'Cancel': function() {
 129+ $j(this).dialog('close');
 130+ }
 131+ },
 132+ }).css({
 133+ 'width':'auto',
 134+ 'height':'auto',
 135+ 'top' : '10px',
 136+ 'left' : '10px',
 137+ 'right' : '10px',
 138+ 'bottom': '10px'
 139+ });
 140+ //@@todo clone the playlist (for faster startup)
127141 /*var this_plObj_Clone = $j('#'+this.id).get(0).cloneNode(true);
128 - this_plObj_Clone.sequencer=true;
129 - this_plObj_Clone.id= 'seq_plobj';
130 - debugger;
 142+ this_plObj_Clone.sequencer=true;
 143+ this_plObj_Clone.id= 'seq_plobj';
 144+ debugger;
131145 */
132146 //load sequencer:
133 - $j("#modalbox").sequencer({
134 - "mv_pl_src":this.src
 147+ $j("#sequencer_target").sequencer({
 148+ "mv_pl_src" : this.src
135149 });
136150
137151 },
Index: branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvSequencer.js
@@ -331,7 +331,7 @@
332332 var tLibSet = mvTransLib['type'][ i ];
333333 for(var j in tLibSet){
334334 trans_name=base_trans_name+'_'+j;
335 - js_log('tname: ' + trans_name);
 335+ js_log('adding tname: ' + trans_name);
336336 o+='<img style="float:left;padding:10px;" '+
337337 'src="'+mv_embed_path +'/skins/'+mv_skin_name+'/transition_images/'+ trans_name + '.png">';
338338 }
Index: branches/new-upload/phase3/js2/mwEmbed/libClipEdit/mvClipEdit.js
@@ -25,7 +25,7 @@
2626 "mv_custom_title":"Custom Title",
2727 "mv_edit_properties":"Edit Properties",
2828 "mv_other_properties":"Other Properties",
29 - "mv_resource_page":"Resource Page",
 29+ "mv_resource_page" : "Resource Page:",
3030
3131 "mv_set_in_out_points": "Set in-out points",
3232 "mv_start_time": "Start Time",
@@ -100,7 +100,9 @@
101101 'media':['image','template'],
102102 'doEdit':function(target, _this ){
103103 //do clock mouse scroll duration editor
104 - $j(target).html('cur dur: ' + _this.rObj.dur );
 104+ $j(target).html(
 105+ _this.getInput
 106+ );
105107 }
106108 },
107109 'inoutpoints':{
Index: branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css
@@ -10,14 +10,13 @@
1111 }
1212
1313 .modal_editor {
14 - background:#AAA none repeat scroll 0 0;
15 - border:3px solid #666666;
16 - left:2px;
17 - top:2px;
18 - right:2px;
19 - position:fixed;
20 - width:99%;
21 - height:99%;
 14+ /*background:#AAA none repeat scroll 0 0;
 15+ border:3px solid #666666;*/
 16+ left:10px;
 17+ top:10px;
 18+ right:10px;
 19+ bottom:10px;
 20+ position:fixed;
2221 z-index:100;
2322 }
2423 .mv_track {
Index: branches/new-upload/phase3/js2/mwEmbed/mv_embed.js
@@ -743,13 +743,15 @@
744744 'mvSequencer'
745745 ];
746746 var secondLoadSet =[];
747 - var uiDepLibs = ['$j.ui.dialog',
 747+ var uiDepLibs = [
 748+ '$j.ui.dialog',
748749 '$j.ui.droppable',
749750 '$j.ui.draggable',
750751 '$j.ui.sortable',
751752 '$j.ui.resizable',
752753 '$j.ui.slider',
753 - '$j.ui.tabs'];
 754+ '$j.ui.tabs'
 755+ ];
754756 if($j.browser.msie || $j.browser.safari){
755757 for(var i=0;i<uiDepLibs.length;i++)
756758 secondLoadSet.push( uiDepLibs[i]);
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js
@@ -159,28 +159,17 @@
160160 }
161161 if(loadPlaylistLib){
162162 mvJsLoader.doLoad([
163 - 'mvPlayList'
 163+ 'mvPlayList',
 164+ '$j.ui', //include dialog for pop-ing up thigns
 165+ '$j.ui.dialog'
164166 ], function(){
165 - $j('playlist').each(function(){
166 - //check if we are in sequence mode load sequence libs (if not already loaded)
167 - if( $j(this).attr('sequencer')=="true" ){
168 - var pl_element = this;
169 - //load the mv_sequencer and the json util lib:
170 - mvJsLoader.doLoad([
171 - 'mvSeqPlayList'
172 - ],function(){
173 - var seqObj = new mvSeqPlayList( pl_element );
174 - mvEmbed.swapEmbedVideoElement( pl_element, seqObj );
175 - }
176 - );
177 - }else{
178 - //create new playlist interface:
179 - var plObj = new mvPlayList( this );
180 - mvEmbed.swapEmbedVideoElement(this, plObj);
181 - var added_height = plObj.pl_layout.title_bar_height + plObj.pl_layout.control_height;
182 - //move into a blocking display container with height + controls + title height:
183 - $j('#'+plObj.id).wrap('<div style="display:block;height:' + (plObj.height + added_height) + 'px;"></div>');
184 - }
 167+ $j('playlist').each(function(){
 168+ //create new playlist interface:
 169+ var plObj = new mvPlayList( this );
 170+ mvEmbed.swapEmbedVideoElement(this, plObj);
 171+ var added_height = plObj.pl_layout.title_bar_height + plObj.pl_layout.control_height;
 172+ //move into a blocking display container with height + controls + title height:
 173+ $j('#'+plObj.id).wrap('<div style="display:block;height:' + (plObj.height + added_height) + 'px;"></div>');
185174 });
186175 });
187176 }
@@ -389,8 +378,10 @@
390379 if(embedObj.userSlide){
391380 embedObj.userSlide=false;
392381 embedObj.seeking=true;
393 - //stop the monitor timer:
394 - embedObj.stopMonitor();
 382+ //stop the monitor timer (if we can)
 383+ if(embedObj.stopMonitor)
 384+ embedObj.stopMonitor();
 385+
395386 var perc = ui.value/1000;
396387 //set seek time (in case we have to do a url seek)
397388 embedObj.seek_time_sec = npt2seconds( embedObj.jump_time, true );

Status & tagging log