r51665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51664‎ | r51665 | r51666 >
Date:22:29, 9 June 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed startOffset listing for java and vlc
Modified paths:
  • /branches/new-upload/phase3/extensions (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/javaEmbed.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/vlcEmbed.js (modified) (history)

Diff [purge]

Property changes on: branches/new-upload/phase3/extensions
___________________________________________________________________
Name: svn:ignore
11 + SemanticMediaWiki
ExternalData
Gadgets
MetavidWiki
OggHandler
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/javaEmbed.js
@@ -89,9 +89,8 @@
9090 //java reads ogg media time.. so no need to add the start or seek offset:
9191 //js_log(' ct: ' + this.jce.getPlayPosition() + ' ' + this.supportsURLTimeEncoding());
9292 this.currentTime = this.jce.getPlayPosition();
93 - if(this.startOffset && ! this.supportsURLTimeEncoding()){
94 - this.currentTime = this.currentTime - this.startOffset;
95 - }
 93+
 94+
9695 if( this.jce.getPlayPosition() < 0){
9796 js_log('pp:'+this.jce.getPlayPosition());
9897 //probably reached clip end
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/vlcEmbed.js
@@ -189,9 +189,7 @@
190190 js_log('setting duration to ' + this.vlc.input.length /1000);
191191 this.duration = this.vlc.input.length /1000;
192192 }
193 - this.currentTime = this.vlc.input.time/1000;
194 - if(this.startOffset)
195 - this.currentTime = this.currentTime - this.startOffset;
 193+ this.currentTime = this.vlc.input.time/1000;
196194 },
197195 onPause: function(){
198196 this.parent_pause(); //update the inteface if paused via native control
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js
@@ -1224,8 +1224,7 @@
12251225 },
12261226 //do seek function (should be overwritten by implementing embedLibs)
12271227 // first check if seek can be done on locally downloaded content.
1228 - doSeek : function( perc ){
1229 - alert('f:baseEmbed:doSeek:' + perc + ' to st:' + this.seek_time_sec + ' sf:' + this.start_ntp);
 1228+ doSeek : function( perc ){
12301229 if( this.supportsURLTimeEncoding() ){
12311230
12321231 //make sure this.seek_time_sec is up-to-date:

Status & tagging log