r51653 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51652‎ | r51653 | r51654 >
Date:17:32, 9 June 2009
Author:werdna
Status:ok
Tags:
Comment:
Fix default check for preferences
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -42,8 +42,9 @@
4343 foreach( $defaultPreferences as $name => &$info ) {
4444 $prefFromUser = self::getOptionFromUser( $name, $info, $user );
4545 $field = HTMLForm::loadInputFromParameters( $info ); // For validation
46 - $globalDefault = isset($wgDefaultUserOptions[$name])
47 - ? $wgDefaultUserOptions[$name]
 46+ $defaultOptions = User::getDefaultOptions();
 47+ $globalDefault = isset($defaultOptions[$name])
 48+ ? $defaultOptions[$name]
4849 : null;
4950
5051 // If it validates, set it as the default

Status & tagging log