r51647 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51646‎ | r51647 | r51648 >
Date:16:06, 9 June 2009
Author:mkroetzsch
Status:deferred
Tags:
Comment:
Better fix for problem with empty URIs for imported vocabulary (unstubbing needs to happen when get- methods are called)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_DV_Import.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_SemanticData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_SemanticData.php
@@ -86,8 +86,6 @@
8787 $dv = SMWDataValueFactory::newPropertyObjectValue($property);
8888 $dv->setDBkeys($dbkeys);
8989
90 - $dv->isValid();
91 -
9290 if ($this->m_noduplicates) {
9391 $this->propvals[$property->getDBkey()][$dv->getHash()] = $dv;
9492 } else {
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_DV_Import.php
@@ -127,10 +127,12 @@
128128 }
129129
130130 public function getShortWikiText($linked = NULL) {
 131+ $this->unstub();
131132 return $this->m_caption;
132133 }
133134
134135 public function getShortHTMLText($linker = NULL) {
 136+ $this->unstub();
135137 return htmlspecialchars($this->m_value);
136138 }
137139
@@ -151,22 +153,27 @@
152154 }
153155
154156 public function getDBkeys() {
 157+ $this->unstub();
155158 return array($this->m_namespace . ' ' . $this->m_section . ' ' . $this->m_uri);
156159 }
157160
158161 public function getWikiValue(){
 162+ $this->unstub();
159163 return $this->m_value;
160164 }
161165
162166 public function getNS(){
 167+ $this->unstub();
163168 return $this->m_uri;
164169 }
165170
166171 public function getNSID(){
 172+ $this->unstub();
167173 return $this->m_namespace;
168174 }
169175
170176 public function getLocalName(){
 177+ $this->unstub();
171178 return $this->m_section;
172179 }
173180 }

Status & tagging log