r51640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51639‎ | r51640 | r51641 >
Date:12:58, 9 June 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Backported r51587 (avoids password failure after upgrade), tweaked release notes.
Modified paths:
  • /branches/REL1_15/phase3 (modified) (history)
  • /branches/REL1_15/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_15/phase3/includes (modified) (history)
  • /branches/REL1_15/phase3/includes/api (modified) (history)
  • /branches/REL1_15/phase3/includes/db (modified) (history)
  • /branches/REL1_15/phase3/includes/parser (modified) (history)
  • /branches/REL1_15/phase3/includes/specials (modified) (history)
  • /branches/REL1_15/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/maintenance/updaters.inc
@@ -144,7 +144,6 @@
145145 array( 'check_bin', 'protected_titles', 'pt_title', 'patch-pt_title-encoding.sql', ),
146146 array( 'maybe_do_profiling_memory_update' ),
147147 array( 'do_filearchive_indices_update' ),
148 - array( 'update_password_format' ),
149148
150149 // 1.14
151150 array( 'add_field', 'site_stats', 'ss_active_users', 'patch-ss_active_users.sql' ),
@@ -258,41 +257,6 @@
259258 }
260259 }
261260
262 -function do_revision_updates() {
263 - global $wgSoftwareRevision;
264 - if ( $wgSoftwareRevision < 1001 ) {
265 - update_passwords();
266 - }
267 -}
268 -
269 -function update_passwords() {
270 - wfDebugDieBacktrace( "This function needs to be updated or removed.\n" );
271 -
272 - global $wgDatabase;
273 - $fname = "Update script: update_passwords()";
274 - wfOut( "\nIt appears that you need to update the user passwords in your\n" .
275 - "database. If you have already done this (if you've run this update\n" .
276 - "script once before, for example), doing so again will make all your\n" .
277 - "user accounts inaccessible, so be sure you only do this once.\n" .
278 - "Update user passwords? (yes/no)" );
279 -
280 - $resp = readconsole();
281 - if ( ! ( "Y" == $resp{0} || "y" == $resp{0} ) ) { return; }
282 -
283 - $sql = "SELECT user_id,user_password FROM user";
284 - $source = $wgDatabase->query( $sql, $fname );
285 -
286 - while ( $row = $wgDatabase->fetchObject( $source ) ) {
287 - $id = $row->user_id;
288 - $oldpass = $row->user_password;
289 - $newpass = md5( "{$id}-{$oldpass}" );
290 -
291 - $sql = "UPDATE user SET user_password='{$newpass}' " .
292 - "WHERE user_id={$id}";
293 - $wgDatabase->query( $sql, $fname );
294 - }
295 -}
296 -
297261 function do_interwiki_update() {
298262 # Check that interwiki table exists; if it doesn't source it
299263 global $wgDatabase, $IP;
@@ -1255,29 +1219,6 @@
12561220 populate_rev_parent_id( $wgDatabase );
12571221 }
12581222
1259 -function update_password_format() {
1260 - if ( update_row_exists( 'password format' ) ) {
1261 - wfOut( "...password hash format already changed\n" );
1262 - return;
1263 - }
1264 -
1265 - wfOut( "Updating password hash format..." );
1266 -
1267 - global $wgDatabase, $wgPasswordSalt;
1268 - $user = $wgDatabase->tableName( 'user' );
1269 - if ( $wgPasswordSalt ) {
1270 - $sql = "UPDATE $user SET user_password=CONCAT(':B:', user_id, ':', user_password) " .
1271 - "WHERE user_password NOT LIKE ':%'";
1272 - } else {
1273 - $sql = "UPDATE $user SET user_password=CONCAT(':A:', user_password) " .
1274 - "WHERE user_password NOT LIKE ':%'";
1275 - }
1276 - $wgDatabase->query( $sql, __METHOD__ );
1277 - $wgDatabase->insert( 'updatelog', array( 'ul_key' => 'password format' ), __METHOD__ );
1278 -
1279 - wfOut( "done\n" );
1280 -}
1281 -
12821223 function sqlite_initial_indexes() {
12831224 global $wgDatabase;
12841225 if ( update_row_exists( 'initial_indexes' ) ) {
Property changes on: branches/REL1_15/phase3/includes/parser
___________________________________________________________________
Name: svn:mergeinfo
12851226 - /trunk/phase3/includes/parser:48836,48886,48892,48989,48992,49002,49051,49068,49086,49142,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470
/trunk/phase3/includes/specials/parser:48993
12861227 + /trunk/phase3/includes/parser:48836,48886,48892,48989,48992,49002,49051,49068,49086,49142,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,51587
/trunk/phase3/includes/specials/parser:48993
Property changes on: branches/REL1_15/phase3/includes/db
___________________________________________________________________
Name: svn:mergeinfo
12871228 - /trunk/phase3/includes/db:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50473,50580,50614
/trunk/phase3/includes/specials/db:48993
12881229 + /trunk/phase3/includes/db:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50473,50580,50614,51587
/trunk/phase3/includes/specials/db:48993
Property changes on: branches/REL1_15/phase3/includes/api
___________________________________________________________________
Name: svn:mergeinfo
12891230 - /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580,50833
12901231 + /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580,50833,51587
Property changes on: branches/REL1_15/phase3/includes/specials
___________________________________________________________________
Name: svn:mergeinfo
12911232 - /trunk/phase3/includes/specials:48836,48886,48892,48989,48992-48993,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580
/trunk/phase3/includes/specials/specials:48993
12921233 + /trunk/phase3/includes/specials:48836,48886,48892,48989,48992-48993,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580,51587
/trunk/phase3/includes/specials/specials:48993
Property changes on: branches/REL1_15/phase3/includes
___________________________________________________________________
Name: svn:mergeinfo
12931234 - /trunk/phase3/includes:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580
/trunk/phase3/includes/specials:48993
12941235 + /trunk/phase3/includes:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580,51587
/trunk/phase3/includes/specials:48993
Index: branches/REL1_15/phase3/RELEASE-NOTES
@@ -3,11 +3,11 @@
44 Security reminder: MediaWiki does not require PHP's register_globals
55 setting since version 1.2.0. If you have it on, turn it *off* if you can.
66
7 -== MediaWiki 1.15.0rc1 ==
 7+== MediaWiki 1.15.0 ==
88
9 -2009-05-16
 9+2009-06-09
1010
11 -This is a release candidate for the the 2009 Q2 branch of MediaWiki.
 11+This is a stable release of the the 2009 Q2 branch of MediaWiki.
1212
1313 MediaWiki is now using a "continuous integration" development model with
1414 quarterly snapshot releases. The latest development code is always kept
@@ -22,7 +22,8 @@
2323
2424 === Changes since 1.15.0rc1 ===
2525
26 -* Removed category redirect feature (bug 3311)
 26+* Removed category redirect feature, implementation was incomplete.
 27+* (bug 18846) Remove update_password_format(), unnecessary, destroys all passwords if a wiki with $wgPasswordSalt=false is upgraded with the web installer.
2728
2829 === Configuration changes in 1.15 ===
2930
Property changes on: branches/REL1_15/phase3
___________________________________________________________________
Name: svn:mergeinfo
3031 - /trunk/phase3:48814,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580
3132 + /trunk/phase3:48814,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580,51587

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51587(bug 18846) Remove update_password_format(), unnecessary, destroys all passwo...tstarling10:26, 8 June 2009

Status & tagging log