r51533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51532‎ | r51533 | r51534 >
Date:10:55, 6 June 2009
Author:ialex
Status:ok
Tags:
Comment:
changed wfMsgExt()'s warnings to use the new wfWarn() so that the caller function is also displayed
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -756,12 +756,12 @@
757757 foreach( $options as $arrayKey => $option ) {
758758 if( !preg_match( '/^[0-9]+|language$/', $arrayKey ) ) {
759759 # An unknown index, neither numeric nor "language"
760 - trigger_error( "wfMsgExt called with incorrect parameter key $arrayKey", E_USER_WARNING );
 760+ wfWarn( "wfMsgExt called with incorrect parameter key $arrayKey", 1, E_USER_WARNING );
761761 } elseif( preg_match( '/^[0-9]+$/', $arrayKey ) && !in_array( $option,
762762 array( 'parse', 'parseinline', 'escape', 'escapenoentities',
763763 'replaceafter', 'parsemag', 'content' ) ) ) {
764764 # A numeric index with unknown value
765 - trigger_error( "wfMsgExt called with incorrect parameter $option", E_USER_WARNING );
 765+ wfWarn( "wfMsgExt called with incorrect parameter $option", 1, E_USER_WARNING );
766766 }
767767 }
768768

Status & tagging log