r51524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51523‎ | r51524 | r51525 >
Date:23:14, 5 June 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed strange IE bug which was caused by using "item" as a name for an iterator in a for-in loop.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -162,11 +162,11 @@
163163 )
164164 .appendTo( groupDiv );
165165 // Appends options
166 - for ( item in section.groups[group][tool].list ) {
 166+ for ( option in section.groups[group][tool].list ) {
167167 selectDiv.append(
168168 $( '<option/>' )
169 - .text( ( section.groups[group][tool].list[item].label || gM( section.groups[group][tool].list[item].labelMsg ) ) )
170 - .attr( 'value', item )
 169+ .text( ( section.groups[group][tool].list[option].label || gM( section.groups[group][tool].list[option].labelMsg ) ) )
 170+ .attr( 'value', option )
171171 );
172172 }
173173 break;

Status & tagging log