r51502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51501‎ | r51502 | r51503 >
Date:13:12, 5 June 2009
Author:ialex
Status:ok
Tags:
Comment:
Fix for r51493, r51084 and realted: use Title::makeTitle() rather than Title::newFromText()
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -447,7 +447,7 @@
448448 $out .= Xml::closeElement( 'fieldset' );
449449
450450 if ( $wgUser->isAllowed( 'editinterface' ) ) {
451 - $title = Title::newFromText( 'Protect-dropdown', NS_MEDIAWIKI );
 451+ $title = Title::makeTitle( NS_MEDIAWIKI, 'Protect-dropdown' );
452452 $link = $wgUser->getSkin()->link(
453453 $title,
454454 wfMsgHtml( 'protect-edit-reasonlist' ),
Index: trunk/phase3/includes/Article.php
@@ -2467,7 +2467,7 @@
24682468
24692469 if( $wgUser->isAllowed( 'editinterface' ) ) {
24702470 $skin = $wgUser->getSkin();
2471 - $title = Title::newFromText( 'Deletereason-dropdown', NS_MEDIAWIKI );
 2471+ $title = Title::makeTitle( NS_MEDIAWIKI, 'Deletereason-dropdown' );
24722472 $link = $skin->link(
24732473 $title,
24742474 wfMsgHtml( 'delete-edit-reasonlist' ),
Index: trunk/phase3/includes/FileDeleteForm.php
@@ -194,7 +194,7 @@
195195
196196 if ( $wgUser->isAllowed( 'editinterface' ) ) {
197197 $skin = $wgUser->getSkin();
198 - $title = Title::newFromText( 'Filedelete-reason-dropdown', NS_MEDIAWIKI );
 198+ $title = Title::makeTitle( NS_MEDIAWIKI, 'Filedelete-reason-dropdown' );
199199 $link = $skin->link(
200200 $title,
201201 wfMsgHtml( 'filedelete-edit-reasonlist' ),
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -636,7 +636,7 @@
637637 $links[] = $this->getContribsLink( $skin );
638638 $links[] = $this->getUnblockLink( $skin );
639639 $links[] = $this->getBlockListLink( $skin );
640 - $title = Title::newFromText( 'Ipbreason-dropdown', NS_MEDIAWIKI );
 640+ $title = Title::makeTitle( NS_MEDIAWIKI, 'Ipbreason-dropdown' );
641641 $links[] = $skin->link(
642642 $title,
643643 wfMsgHtml( 'ipb-edit-dropdown' ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51084Fix a usability issue on protect and [file ]delete forms. "Edit ... reasons" ...siebrand20:35, 27 May 2009
r51493Follow-up to r51084:...siebrand07:33, 5 June 2009

Status & tagging log