r51490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51489‎ | r51490 | r51491 >
Date:06:30, 5 June 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
Escaping and formatNum
Modified paths:
  • /trunk/phase3/includes/specials/SpecialTags.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialTags.php
@@ -49,20 +49,22 @@
5050 if ( in_array( $tag, $doneTags ) ) {
5151 return '';
5252 }
 53+
 54+ global $wgLang;
5355
5456 $newRow = '';
5557 $newRow .= Xml::tags( 'td', null, Xml::element( 'tt', null, $tag ) );
5658
5759 $disp = ChangeTags::tagDescription( $tag );
58 - $disp .= ' (' . $sk->link( Title::makeTitle( NS_MEDIAWIKI, "Tag-$tag" ), wfMsg( 'tags-edit' ) ) . ')';
 60+ $disp .= ' (' . $sk->link( Title::makeTitle( NS_MEDIAWIKI, "Tag-$tag" ), wfMsgHtml( 'tags-edit' ) ) . ')';
5961 $newRow .= Xml::tags( 'td', null, $disp );
6062
6163 $desc = wfMsgExt( "tag-$tag-description", 'parseinline' );
6264 $desc = wfEmptyMsg( "tag-$tag-description", $desc ) ? '' : $desc;
63 - $desc .= ' (' . $sk->link( Title::makeTitle( NS_MEDIAWIKI, "Tag-$tag-description" ), wfMsg( 'tags-edit' ) ) . ')';
 65+ $desc .= ' (' . $sk->link( Title::makeTitle( NS_MEDIAWIKI, "Tag-$tag-description" ), wfMsgHtml( 'tags-edit' ) ) . ')';
6466 $newRow .= Xml::tags( 'td', null, $desc );
6567
66 - $hitcount = wfMsgExt( 'tags-hitcount', array( 'parsemag' ), $hitcount );
 68+ $hitcount = wfMsgExt( 'tags-hitcount', array( 'parsemag' ), $wgLang->formatNum( $hitcount ) );
6769 $hitcount = $sk->link( SpecialPage::getTitleFor( 'Recentchanges' ), $hitcount, array(), array( 'tagfilter' => $tag ) );
6870 $newRow .= Xml::tags( 'td', null, $hitcount );
6971

Status & tagging log