r51481 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51480‎ | r51481 | r51482 >
Date:23:39, 4 June 2009
Author:aaron
Status:deferred
Tags:
Comment:
Added extra $wgAllowAccountRequestFiles check
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -437,7 +437,7 @@
438438
439439 $this->showSuccess( $this->submitType );
440440 } else if( $this->submitType === 'accept' ) {
441 - global $wgAuth, $wgConfirmAccountSaveInfo;
 441+ global $wgAuth, $wgConfirmAccountSaveInfo, $wgAllowAccountRequestFiles;
442442 # Now create user and check if the name is valid
443443 $user = User::newFromName( $this->mUsername, 'creatable' );
444444 if( is_null($user) ) {
@@ -478,7 +478,7 @@
479479 if( $wgConfirmAccountSaveInfo ) {
480480 # Copy any attached files to new storage group
481481 $key = $row->acr_storage_key;
482 - if( $key ) {
 482+ if( $wgAllowAccountRequestFiles && $key ) {
483483 $storeOld = FileStore::get( 'accountreqs' );
484484 $storeNew = FileStore::get( 'accountcreds' );
485485 if( !$storeOld || !$storeNew ) {

Status & tagging log