r51447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51446‎ | r51447 | r51448 >
Date:02:35, 4 June 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed layout of download link for ie6
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_baseEmbed.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_baseEmbed.js
@@ -1722,16 +1722,17 @@
17231723 o+='<a class="email" href="'+this.linkback+'">Share Clip via Link</a> '+
17241724 '<p>or</p> ';
17251725 }
1726 - o+='<span style="color:#FFF;font-size:14px;">Embed Clip in Blog or Site</span><br>'+
1727 - '<span style="color:#FFF;font-size:12px;"><a style="color:red" href="http://metavid.org/wiki/Security_Notes_on_Remote_Embedding">'+
1728 - 'Read This</a> before embeding.</span>'+
1729 - '<div class="embed_code"> '+
1730 - '<textarea onClick="this.select();" id="embedding_user_html_'+this.id+'" name="embed">' +
1731 - embed_code+
1732 - '</textarea> '+
1733 - '<button onClick="$j(\'#'+this.id+'\').get(0).copyText(); return false;" class="copy_to_clipboard">Copy to Clipboard</button> '+
1734 - '</div> '+
1735 - '</div>';
 1726+ o+='<div>' +
 1727+ '<span style="color:#FFF;font-size:14px;">Embed Clip in Blog or Site</span><br>'+
 1728+ '<span style="color:#FFF;font-size:12px;"><a style="color:red" href="http://metavid.org/wiki/Security_Notes_on_Remote_Embedding">'+
 1729+ 'Read This</a> before embeding.</span>'+
 1730+ '<div class="embed_code"> '+
 1731+ '<textarea onClick="this.select();" id="embedding_user_html_'+this.id+'" name="embed">' +
 1732+ embed_code+
 1733+ '</textarea> '+
 1734+ '<button onClick="$j(\'#'+this.id+'\').get(0).copyText(); return false;" class="copy_to_clipboard">Copy to Clipboard</button> '+
 1735+ '</div> '+
 1736+ '</div>';
17361737 this.displayHTML(o);
17371738 },
17381739 copyText:function(){
@@ -1787,7 +1788,7 @@
17881789 },
17891790 /** Generic function to display custom HTML inside the mv_embed element.
17901791 The code should call the closeDisplayedHTML function to close the
1791 - display of the custom HTML and restore the regular mv_embed display.
 1792+ display of the custom HTML and restore the regular mv_embed display.
17921793 @param {String} HTML code for the selection list.
17931794 */
17941795 displayHTML:function(html_code)
@@ -1816,7 +1817,6 @@
18171818 //fade in a black bg div ontop of everything
18181819 var div_code = '<div id="blackbg_'+sel_id+'" class="videoComplete" ' +
18191820 'style="height:'+parseInt(height)+'px;width:'+parseInt(width)+'px;">'+
1820 -// '<span class="displayHTML" id="con_vl_'+this.id+'" style="position:absolute;top:20px;left:20px;color:white;">' +
18211821 '<div class="videoOptionsComplete">'+
18221822 //@@TODO: this style should go to .css
18231823 '<span style="float:right;margin-right:10px">' +
@@ -1825,7 +1825,6 @@
18261826 '<div id="mv_disp_inner_'+sel_id+'" style="padding-top:10px;">'+
18271827 html_code
18281828 +'</div>'+
1829 -// close_link+'</span>'+
18301829 '</div></div>';
18311830 $j('#'+sel_id).prepend(div_code);
18321831 if (fade_in)
@@ -1942,11 +1941,12 @@
19431942 }
19441943 },
19451944 getShowVideoDownload:function(){
1946 - var out='<b style="color:white;">'+gM('download_segment')+'</b><br>';
1947 - out+='<span style="color:white"><blockquote style="background:#000">';
 1945+ var out='<div style="color:white">' +
 1946+ '<b style="color:white;">'+gM('download_segment')+'</b><br>';
 1947+ out+='<blockquote style="background:#000">'+
 1948+ gM('download_right_click') + '</blockquote><br>';
19481949 var dl_list='';
1949 - var dl_txt_list='';
1950 -
 1950+ var dl_txt_list='';
19511951 $j.each(this.media_element.getSources(), function(index, source){
19521952 var dl_line = '<li>' + '<a style="color:white" href="' + source.getURI() +'"> '
19531953 + source.getTitle()+'</a> '+ '</li>'+"\n";
@@ -1957,13 +1957,14 @@
19581958 }else{
19591959 dl_list+=dl_line;
19601960 }
1961 - });
1962 - out+= gM('download_right_click') + '<br>';
 1961+ });
 1962+
19631963 if(dl_list!='')
1964 - out+='</blockquote>'+gM('download_full') + '<blockquote style="background:#000">' + dl_list + '</blockquote>';
 1964+ out+=gM('download_full') + '<blockquote style="background:#000">' + dl_list + '</blockquote>';
19651965 if(dl_txt_list!='')
1966 - out+='</blockquote>'+gM('download_text')+'<blockquote style="background:#000">' + dl_txt_list +'</blockquote></span>';
1967 - return out;
 1966+ out+=gM('download_text')+'<blockquote style="background:#000">' + dl_txt_list +'</blockquote>';
 1967+ out+='</div>';
 1968+ return out;
19681969 },
19691970 /*
19701971 * base embed controls

Status & tagging log