r51446 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51445‎ | r51446 | r51447 >
Date:02:20, 4 June 2009
Author:dale
Status:deferred
Tags:
Comment:
some more ie6 improvements around java support
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_javaEmbed.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_javaEmbed.js
@@ -16,8 +16,9 @@
1717 'volume_control':false
1818 },
1919 getEmbedHTML : function (){
 20+ //big delay on embed html cuz its just for status updates and ie6 is crazy.
2021 if(this.controls)
21 - setTimeout('document.getElementById(\''+this.id+'\').postEmbedJS()', 150);
 22+ setTimeout('document.getElementById(\''+this.id+'\').postEmbedJS()', 500);
2223 //set a default duration of 30 seconds: cortao should detect duration.
2324 return this.wrapEmebedContainer( this.getEmbedObj() );
2425 },
@@ -52,8 +53,9 @@
5354 '<param name="audio" value="true" />'+"\n"+
5455 '<param name="seekable" value="true" />'+"\n"+
5556 '<param name="duration" value="' + this.duration + '" />'+"\n"+
56 - '<param name="bufferSize" value="200" />'+"\n"+
57 - '</applet>';
 57+ '<param name="bufferSize" value="4096" />'+"\n"+
 58+ '</applet>';
 59+
5860 // Wrap it in an iframe to avoid hanging the event thread in FF 2/3 and similar
5961 // Doesn't work in MSIE or Safari/Mac or Opera 9.5
6062 if ( embedTypes.mozilla ) {
@@ -82,7 +84,7 @@
8385 },
8486 monitor:function(){
8587 this.getJCE()
86 - if(this.jce){
 88+ if(this.jce && this.jce.getPlayPosition){
8789 try{
8890 //java reads ogg media time.. so no need to add the start or seek offset:
8991 //js_log(' ct: ' + this.jce.getPlayPosition() + ' ' + this.supportsURLTimeEncoding());

Status & tagging log