r51429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51428‎ | r51429 | r51430 >
Date:18:51, 3 June 2009
Author:kim
Status:deferred
Tags:
Comment:
BaseException.message is deprecated between python 2.5 and 2.6
Modified paths:
  • /trunk/testing/installer/installers.py (modified) (history)

Diff [purge]

Index: trunk/testing/installer/installers.py
@@ -43,7 +43,7 @@
4444 try:
4545 ppath=parse_path(" ".join(args[1:]))
4646 except Parse_Exception,e:
47 - print e.message
 47+ print str(e)
4848 return
4949
5050 try:
@@ -56,7 +56,7 @@
5757 elif ppath['ai']=='installed' or ppath['ai']==None: # XXX hardcoded default
5858 output=ls_installed(ppath)
5959 except Listing_Exception,e:
60 - print e.message
 60+ print str(e)
6161 return
6262
6363 if output==None:
@@ -110,7 +110,7 @@
111111 try:
112112 installed=system.get_installed()
113113 except Installer_Exception,e:
114 - print e.message
 114+ print str(e)
115115 return
116116
117117 return installed
@@ -129,7 +129,7 @@
130130 try:
131131 revisions=system.get_revisions(ppath["installer"])
132132 except Installer_Exception, e:
133 - raise Listing_Exception(e.message)
 133+ raise Listing_Exception(str(e))
134134
135135 return revisions
136136
@@ -147,7 +147,7 @@
148148 try:
149149 tags=system.get_tags(ppath["installer"])
150150 except TagsException, e:
151 - raise Listing_Exception(e.message)
 151+ raise Listing_Exception(str(e))
152152
153153 return tags
154154
@@ -160,7 +160,7 @@
161161 try:
162162 ppath=parse_path(" ".join(args[1:]),defaults={'ai':'available'})
163163 except Parse_Exception,e:
164 - print e.message
 164+ print str(e)
165165 return
166166
167167 if not ppath["ai"]:
@@ -176,7 +176,7 @@
177177 try:
178178 mw.duplicate(args[1],args[2])
179179 except Mediawiki_Installer_Exception,e:
180 - print e.message
 180+ print str(e)
181181
182182
183183 def install(args):
@@ -189,7 +189,7 @@
190190 try:
191191 ppath=parse_path(" ".join(args[1:]), defaults={'ai':'available','system':'mediawiki'})
192192 except Parse_Exception,e:
193 - print e.message
 193+ print str(e)
194194 return
195195
196196 if ppath["ai"]=="installed":
@@ -216,7 +216,7 @@
217217 print "Install failed."
218218
219219 except Installer_Exception,e:
220 - print e.message
 220+ print str(e)
221221
222222 def test(args):
223223 if len(args)<2:
@@ -243,7 +243,7 @@
244244 try:
245245 ppath=parse_path(" ".join(args[1:]),defaults={'ai':'installed','system':'mediawiki'})
246246 except Parse_Exception,e:
247 - print e.message
 247+ print str(e)
248248 return
249249
250250 if ppath["ai"]=="available":
@@ -262,7 +262,7 @@
263263 else:
264264 print "Uninstall failed."
265265 except Installer_Exception,e:
266 - print e.message
 266+ print str(e)
267267 return
268268
269269

Status & tagging log