r51416 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51415‎ | r51416 | r51417 >
Date:16:33, 3 June 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Fix for r49412, possible fatal errors.
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -46,7 +46,12 @@
4747 function __construct( $titleObj = null, $old = 0, $new = 0, $rcid = 0,
4848 $refreshCache = false, $htmldiff = false, $unhide = false )
4949 {
50 - $this->mTitle = $titleObj;
 50+ if ( $titleObj ) {
 51+ $this->mTitle = $titleObj;
 52+ } else {
 53+ global $wgTitle;
 54+ $this->mTitle = $wgTitle;
 55+ }
5156 wfDebug("DifferenceEngine old '$old' new '$new' rcid '$rcid'\n");
5257
5358 if ( 'prev' === $new ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49412No more $wgTitle in the diff engine.demon18:23, 11 April 2009

Status & tagging log