r51312 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51311‎ | r51312 | r51313 >
Date:21:29, 1 June 2009
Author:gmaxwell
Status:ok
Tags:
Comment:
OggHandler audio fix in r51265 produced incoorect HTML.
Modified paths:
  • /trunk/extensions/OggHandler/OggPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggPlayer.js
@@ -542,8 +542,9 @@
543543
544544 'embedVideoElement': function ( elt, params ) {
545545 var id = elt.id + "_obj";
 546+ var mtag = (params.isVideo?'video':'audio');
546547 var html =
547 - '<div><' + (params.isVideo?'video':'audio') +
 548+ '<div><' + mtag +
548549 ' id=' + this.hq( id ) +
549550 ' width=' + this.hq( params.width ) +
550551 ' height=' + this.hq( (params.height>0)?params.height:this.controlsHeightGuess ) +
@@ -551,7 +552,7 @@
552553 ' autoplay';
553554 if (!this.safari)
554555 html += ' controls';
555 - html += ' ></video></div>';
 556+ html += ' ></' + mtag + '></div>';
556557 elt.innerHTML = html;
557558 },
558559

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51265Use audio tag for non-video files; Firefox 3.5pre 20090531 is failing to prov...gmaxwell22:50, 31 May 2009

Status & tagging log