r51291 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r51290‎ | r51291 | r51292 >
Date:16:16, 1 June 2009
Author:aaron
Status:reverted
Tags:
Comment:
Tweak r51279: re-added ability to hide comment/user of top revision
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
——@@ -170,11 +170,13 @@
171171 $qc = $this->getLogQueryCond();
172172 # Show relevant lines from the deletion log
173173 $wgOut->addHTML( "<h2>" . htmlspecialchars( LogPage::logName( 'delete' ) ) . "</h2>\n" );
174 - LogEventsList::showLogExtract( $wgOut, 'delete', $this->targetObj->getPrefixedText(), '', 25, $qc );
 174+ LogEventsList::showLogExtract( $wgOut, 'delete',
 175+ $this->targetObj->getPrefixedText(), '', 25, $qc );
175176 # Show relevant lines from the suppression log
176177 if( $wgUser->isAllowed( 'suppressionlog' ) ) {
177178 $wgOut->addHTML( "<h2>" . htmlspecialchars( LogPage::logName( 'suppress' ) ) . "</h2>\n" );
178 - LogEventsList::showLogExtract( $wgOut, 'suppress', $this->targetObj->getPrefixedText(), '', 25, $qc );
 179+ LogEventsList::showLogExtract( $wgOut, 'suppress',
 180+ $this->targetObj->getPrefixedText(), '', 25, $qc );
179181 }
180182 }
181183
——@@ -293,7 +295,8 @@
294296 if ( $this->typeName == 'logging' ) {
295297 $wgOut->addWikiMsg( 'logdelete-selected', $wgLang->formatNum( count($this->ids) ) );
296298 } else {
297 - $wgOut->addWikiMsg( 'revdelete-selected', $this->targetObj->getPrefixedText(), count( $this->ids ) );
 299+ $wgOut->addWikiMsg( 'revdelete-selected',
 300+ $this->targetObj->getPrefixedText(), count( $this->ids ) );
298301 }
299302
300303 $bitfields = 0;
——@@ -644,7 +647,8 @@
645648 $opType = 'modify';
646649 }
647650
648 - if ( $item->isCurrent() && $opType == 'hide' ) {
 651+ // TODO: use FILE::DELETED_FILE, though value is the same
 652+ if ( $item->isCurrent() && ($newBits & Revision::DELETED_TEXT) ) {
649653 // Cannot hide current version text
650654 $status->error( 'revdelete-hide-current', $item->formatDate(), $item->formatTime() );
651655 $status->failCount++;

Follow-up revisions

RevisionCommit summaryAuthorDate
r51325Reverted r51291 (including random formatting changes) and reimplemented in a ...tstarling03:51, 2 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51279In Special:RevisionDelete:...tstarling11:37, 1 June 2009

Status & tagging log