r51220 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51219‎ | r51220 | r51221 >
Date:09:07, 31 May 2009
Author:daniel
Status:deferred
Tags:
Comment:
MappingFeatureStore vs. raw mapping store
Modified paths:
  • /trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/mapping/MappingPassThrough.java (modified) (history)
  • /trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/mapping/MappingProcessor.java (modified) (history)
  • /trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/mapping/OptimalMappingSelector.java (modified) (history)
  • /trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/store/MappingFeatureStore.java (added) (history)
  • /trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/store/MappingStore.java (deleted) (history)

Diff [purge]

Index: trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/mapping/OptimalMappingSelector.java
@@ -11,7 +11,7 @@
1212 import de.brightbyte.data.cursor.DataCursor;
1313 import de.brightbyte.util.PersistenceException;
1414 import de.brightbyte.wikiword.integrator.data.FeatureSet;
15 -import de.brightbyte.wikiword.integrator.store.MappingStore;
 15+import de.brightbyte.wikiword.integrator.store.MappingFeatureStore;
1616
1717 public class OptimalMappingSelector implements MappingProcessor {
1818
@@ -35,7 +35,7 @@
3636 }
3737
3838 public void processMappings(DataCursor<MappingCandidates> cursor,
39 - MappingStore store) throws PersistenceException {
 39+ MappingFeatureStore store) throws PersistenceException {
4040
4141 MappingCandidates m;
4242 while ((m = cursor.next()) != null ) {
Index: trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/mapping/MappingPassThrough.java
@@ -3,12 +3,12 @@
44 import de.brightbyte.data.cursor.DataCursor;
55 import de.brightbyte.util.PersistenceException;
66 import de.brightbyte.wikiword.integrator.data.FeatureSet;
7 -import de.brightbyte.wikiword.integrator.store.MappingStore;
 7+import de.brightbyte.wikiword.integrator.store.MappingFeatureStore;
88
99 public class MappingPassThrough implements MappingProcessor {
1010
1111 public void processMappings(DataCursor<MappingCandidates> cursor,
12 - MappingStore store) throws PersistenceException {
 12+ MappingFeatureStore store) throws PersistenceException {
1313
1414 MappingCandidates m;
1515 while ((m = cursor.next()) != null ) {
Index: trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/mapping/MappingProcessor.java
@@ -2,8 +2,8 @@
33
44 import de.brightbyte.data.cursor.DataCursor;
55 import de.brightbyte.util.PersistenceException;
6 -import de.brightbyte.wikiword.integrator.store.MappingStore;
 6+import de.brightbyte.wikiword.integrator.store.MappingFeatureStore;
77
88 public interface MappingProcessor {
9 - public void processMappings(DataCursor<MappingCandidates> cursor, MappingStore store) throws PersistenceException;
 9+ public void processMappings(DataCursor<MappingCandidates> cursor, MappingFeatureStore store) throws PersistenceException;
1010 }
Index: trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/store/MappingStore.java
@@ -1,8 +0,0 @@
2 -package de.brightbyte.wikiword.integrator.store;
3 -
4 -import de.brightbyte.util.PersistenceException;
5 -import de.brightbyte.wikiword.integrator.data.FeatureSet;
6 -
7 -public interface MappingStore {
8 - public void storeMapping(FeatureSet source, FeatureSet target, FeatureSet props) throws PersistenceException;
9 -}
Index: trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/store/MappingFeatureStore.java
@@ -0,0 +1,8 @@
 2+package de.brightbyte.wikiword.integrator.store;
 3+
 4+import de.brightbyte.util.PersistenceException;
 5+import de.brightbyte.wikiword.integrator.data.FeatureSet;
 6+
 7+public interface MappingFeatureStore {
 8+ public void storeMapping(FeatureSet source, FeatureSet target, FeatureSet props) throws PersistenceException;
 9+}
Property changes on: trunk/WikiWord/WikiWordIntegrator/src/main/java/de/brightbyte/wikiword/integrator/store/MappingFeatureStore.java
___________________________________________________________________
Name: svn:mergeinfo
110 +

Status & tagging log